-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java-openliberty-gradle devfile #350
Conversation
Signed-off-by: dkwon17 <dakwon@redhat.com>
Hi @dkwon17. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkwon17 I think here we should also bump up the version of the devfile
version: 0.4.0 |
I'd suggest bumping up to 0.5.0
Co-authored-by: Theofanis Petkos <thepetk@gmail.com> Signed-off-by: dkwon17 <dakwon@redhat.com>
11e6498
to
fc23f7e
Compare
Thank you, I fixed the changes, but I had to force push to my branch to remove the unsigned commit |
/ok-to-test |
Thanks! @ajm01 as you are the owner of the stack could you please review the PR? /hold |
Note there's a known issue with a failing check and we're working to address it: devfile/api#1494. |
@ajm01 kind reminder to review the PR as you are listed as an owner. As discussed in the devfiles community call, we will wait for a week, until 23 Apr 2024, so the owner has time to review. In case we don't have a review from the owner, the devfile services team will review & merge the updates to unblock the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged |
What does this PR do?:
This PR updates the java-openliberty-gradle sample:
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: