-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs-nuxtjs stack #346
Conversation
Hi @RomanNikitenko. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I see that So, version |
@RomanNikitenko I believe that the CI tests for validating the stacks aren't updated to the latest commit hash that would contain the change to devfile library that increased the supported schema versions. I will open an issue so that we can update those hashes and get this unblocked for you. See:
Line 7 in 72a45de
devfile/library@44ca18d |
I believe this open issue would cover the changes required to unblock these ci checks? @michael-valdron |
Yes I think that the |
We can do this to unblock this PR and update to |
/retest |
@Jdubrick we'll need to rebase to your changes FYI @RomanNikitenko |
f23686e
to
9df518e
Compare
Digged a little bit further for this issue and opened devfile/api#1494. We should also update the version of library used by odo in order to be able to support Another question is if we would like to remove the |
I've merged the temporary fix and now the check should be passing |
Might need a rebase @RomanNikitenko :( |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
9df518e
to
0dcbb26
Compare
|
/retest |
Please let me know if any changes are required on my part to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RomanNikitenko, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED Signed-off-by: thepetk <thepetk@gmail.com>
What does this PR do?:
Updates
nodejs-nuxtjs
stack:1.2.1
schemaVersion: 2.2.2
https
protocol for the endpoint1.2.1
version as a default oneWhich issue(s) this PR fixes:
eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
You can use the following link to start a workspace for testing:
https://workspaces.openshift.com/#https://raw.githubusercontent.com/RomanNikitenko/registry/update-nuxtjs/stacks/nodejs-nuxtjs/1.2.1/devfile.yaml
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED