Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default version for java-wildfly-bootable-jar stack; set https protocol #345

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Mar 26, 2024

What does this PR do?:

Updates java-wildfly-bootable-jar stack:

Add new version 1.3.0

  • Set HTTPS protocol for the endpoint
  • Set the 1.3.0 version as the default one

Знімок екрана 2024-03-26 о 17 41 39

Знімок екрана 2024-03-26 о 17 44 02

Which issue(s) this PR fixes:

eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Mar 26, 2024

Hi @olexii4. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olexii4 olexii4 force-pushed the java-websphereliberty-gradle branch 2 times, most recently from 5eeb06b to f002386 Compare March 26, 2024 15:00
@olexii4 olexii4 marked this pull request as ready for review March 26, 2024 15:46
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest bumping up to 1.3.0 instead of 1.2.1 because the schemaVersion goes from 2.1.0 to 2.2.2.

@ehsavoie as you are the owner of the stack could you please review the PR?

Another comment is if we would like to remove the version 1.2.0 completely (dir and stack.yaml record) like we did for #342

cc @michael-valdron @Jdubrick

@thepetk
Copy link
Contributor

thepetk commented Apr 1, 2024

/ok-to-test

@olexii4
Copy link
Contributor Author

olexii4 commented Apr 1, 2024

@thepetk I have fixed the version.

@Jdubrick
Copy link
Contributor

Jdubrick commented Apr 2, 2024

I'd suggest bumping up to 1.3.0 instead of 1.2.1 because the schemaVersion goes from 2.1.0 to 2.2.2.

@ehsavoie as you are the owner of the stack could you please review the PR?

Another comment is if we would like to remove the version 1.2.0 completely (dir and stack.yaml record) like we did for #342

cc @michael-valdron @Jdubrick

I think in this case we leave 1.2.0 because it is unchanged and we are adding 1.3.0 in addition, so people can choose to still reference 1.2.0 if they want by leaving it, wdyt?

Also @olexii4 you will need to sign your latest commit for DCO check to pass :)

@thepetk
Copy link
Contributor

thepetk commented Apr 2, 2024

I'd suggest bumping up to 1.3.0 instead of 1.2.1 because the schemaVersion goes from 2.1.0 to 2.2.2.
@ehsavoie as you are the owner of the stack could you please review the PR?
Another comment is if we would like to remove the version 1.2.0 completely (dir and stack.yaml record) like we did for #342
cc @michael-valdron @Jdubrick

I think in this case we leave 1.2.0 because it is unchanged and we are adding 1.3.0 in addition, so people can choose to still reference 1.2.0 if they want by leaving it, wdyt?

Also @olexii4 you will need to sign your latest commit for DCO check to pass :)

Yeah I agree, that's why I had the doubt on this - cause the two versions have different schema versions. +1 on keeping the old version.

…t https protocol

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 force-pushed the java-websphereliberty-gradle branch from 9c0676b to c1c065d Compare April 2, 2024 16:02
@olexii4
Copy link
Contributor Author

olexii4 commented Apr 2, 2024

I'd suggest bumping up to 1.3.0 instead of 1.2.1 because the schemaVersion goes from 2.1.0 to 2.2.2.
@ehsavoie as you are the owner of the stack could you please review the PR?
Another comment is if we would like to remove the version 1.2.0 completely (dir and stack.yaml record) like we did for #342
cc @michael-valdron @Jdubrick

I think in this case we leave 1.2.0 because it is unchanged and we are adding 1.3.0 in addition, so people can choose to still reference 1.2.0 if they want by leaving it, wdyt?

Also @olexii4 you will need to sign your latest commit for DCO check to pass :)

I have fixed it.

@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

/hold as we need the approval from the owner to merge the pr

@michael-valdron
Copy link
Member

Another comment is if we would like to remove the version 1.2.0 completely (dir and stack.yaml record) like we did for #342

@thepetk #347 (comment)

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 18, 2024
@Jdubrick
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsavoie, Jdubrick, olexii4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor

/unhold

@thepetk thepetk merged commit 38d76c0 into devfile:main Apr 18, 2024
10 checks passed
@olexii4 olexii4 deleted the java-websphereliberty-gradle branch April 19, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants