Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .devfile.yaml and parse from a path #73

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

yangcao77
Copy link
Collaborator

Signed-off-by: Stephanie yangcao@redhat.com

What does this PR do?

Supports parse from a path which contains devfile.yaml or .devfile.yaml
If the path/url does not ends with .yaml, than assumes the value is a directory, and will check for devfile.yaml or .devfile.yaml under that directory
devfile.yaml takes priority than .devfile.yaml

What issues does this PR fix or reference?

Fixes devfile/api#61

Is your PR tested? Consider putting some instruction how to test your changes

manually tested

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we think about adding Populate() unit tests for these use cases? WDYT

pkg/util/util.go Outdated Show resolved Hide resolved
pkg/devfile/parser/context/context.go Outdated Show resolved Hide resolved
pkg/devfile/parser/context/context.go Outdated Show resolved Hide resolved
pkg/devfile/parser/context/context.go Outdated Show resolved Hide resolved
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow .devfile.yaml
3 participants