Add ubuntu server bypass error case for invalid registry urls #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N/A |
|
/hold Need to amend error pattern for compatibility with expected errors, in the event this is fixed. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
fix/test-parse-registry-ubuntu-server-bypass
branch
from
73e917f
to
0f4adc4
Compare
|
/unhold |
Merged
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jdubrick
added a commit
that referenced
this pull request
Aug 15, 2024
* update schema version to 2.2.2 for nodejs test child devfiles (#213) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add ubuntu server bypass error case for invalid registry urls (#217) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Fix parent version on test devfile (#216) * Fix parent version on test devfile Signed-off-by: thepetk <thepetk@gmail.com> * Update parent version Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com> * bump k8s api (#212) Signed-off-by: Kartikey-star <kmamgain@redhat.com> * update references to Go 1.21 in docs (#218) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Add support for 2.3.0 schema version (#219) * updateApi.sh script includes newer schema versions Signed-off-by: Michael Valdron <mvaldron@redhat.com> * devfile 2.3.0 support Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert schema versions for testing older features Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Bump github.com/docker/docker (#221) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.6+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.1...v25.0.6) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update readme for 2.3.0 schema (#222) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com> Signed-off-by: Kartikey-star <kmamgain@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Co-authored-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Theofanis Petkos <thepetk@gmail.com> Co-authored-by: Kartikey Mamgain <mamgainkartikey@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds a bypass error case to expect
Get "http://http//invalid.com/devfiles/notexist/": dial tcp: lookup http on 127.0.0.53:53: server misbehavingfor invalid registry urls in Ubuntu Server instances, which are the instances known to give this error for invalid urls when usingGo 1.21.Which issue(s) this PR fixes:
fixes devfile/api#1588
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Unit/Functional tests
QE Integration test
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Use
Go 1.21.10under an Ubuntu Server 22.04 LTS instances and run: