Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SECURITY-Insights.md #199

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 1, 2024

What does this PR do?

As part of the CNCF defender tasks we need to add a security-insights.md to reach the 100% on the monitor. More information for the security insights here: https://github.com/ossf/security-insights-spec/blob/main/specification.md

Which issue(s) does this PR fix

Fixes devfile/api#1374

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 1, 2024 14:10
@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (eefdbd3) to head (c8a04bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files          43       43           
  Lines        5103     5103           
=======================================
  Hits         3107     3107           
  Misses       1809     1809           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: thepetk <thepetk@gmail.com>
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 9b0873b into devfile:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devfile/library CNCF Defender tasks
2 participants