Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use git checkout instead of switch #173

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

mike-hoang
Copy link
Contributor

@mike-hoang mike-hoang commented May 19, 2023

What does this PR do?:

  • Uses git checkout instead of git switch to change revisions.
  • Attempt resource download only if uri is a supported git repo.

Which issue(s) this PR fixes:

devfile/api#1119

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.11 🎉

Comparison is base (d32bcd6) 59.62% compared to head (ce6a7d5) 59.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   59.62%   59.73%   +0.11%     
==========================================
  Files          41       41              
  Lines        5119     5119              
==========================================
+ Hits         3052     3058       +6     
+ Misses       1873     1866       -7     
- Partials      194      195       +1     
Impacted Files Coverage Δ
pkg/devfile/parser/parse.go 60.80% <0.00%> (ø)
pkg/git/mock.go 0.00% <0.00%> (ø)
pkg/git/git.go 82.85% <100.00%> (+2.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Hoang <mhoang@redhat.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, mike-hoang
Once this PR has been reviewed and has the lgtm label, please assign yangcao77 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-hoang mike-hoang merged commit 04a8b3f into devfile:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants