Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change func param signature to avoid unneccessary Ctx #154

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

maysunfaisal
Copy link
Member

Signed-off-by: Maysun J Faisal maysunaneek@gmail.com

What does this PR do?:

Changes the util func param signature to take in Devfile data rather than Devfile object. Because we dont need DevfileObj.Ctx and is unnecessary export available in the function

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Tests should pass

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2022

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 58.95% // Head: 58.95% // No change to project coverage 👍

Coverage data is based on head (b5c3f6a) compared to base (63790be).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          36       36           
  Lines        4037     4037           
=======================================
  Hits         2380     2380           
  Misses       1518     1518           
  Partials      139      139           
Impacted Files Coverage Δ
pkg/devfile/parser/utils.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maysunfaisal maysunfaisal merged commit c8f6c26 into devfile:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants