Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External variables can override Devfile variables #136

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 17, 2022

What does this PR do?:

This PR adds an ExternalVariables option to the ParserArgs structure, to be able to override variables defined in the devfile with other values when parsing a Devfile.

Which issue(s) this PR fixes:

redhat-developer/odo#5489

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from elsony and kim-tsao May 17, 2022 08:09
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@yangcao77
Copy link
Collaborator

Do you mind adding a unit test case for the ExternalVariables?

@feloy
Copy link
Contributor Author

feloy commented May 17, 2022

Do you mind adding a unit test case for the ExternalVariables?

Sure, I'll add a unit test case

Signed-off-by: Philippe Martin <phmartin@redhat.com>
Copy link
Collaborator

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants