new fields autobuild and deploybydefault for image components and kubernetes/openshift components
#127
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
| @@ -457,6 +457,10 @@ const JsonSchema220 = `{ | |||
| } | |||
| ], | |||
| "properties": { | |||
| "autoBuild": { | |||
| "description": "Defines if the image should be built during startup Default is false", | |||
There was a problem hiding this comment.
Default is false should be a separate sentence. Can we update it to Default value is 'false' so it's consistent with other descriptions?
There was a problem hiding this comment.
This requires api change, PR created: devfile/api#718
Can you help review and approve that PR?
There was a problem hiding this comment.
updated the PR with the latest schema which includes the description change
Signed-off-by: Stephanie <yangcao@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie yangcao@redhat.com
What does this PR do?:
pull latest devfile/api pkg and schema which contains the new field
autobuildanddeploybydefaultfor image components and kubernetes/openshift components, respectively.Which issue(s) this PR fixes:
Fixes devfile/api#693
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: