Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #106

Merged
merged 1 commit into from
Jul 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,35 @@
### What does this PR do?
### What does this PR do?:
<!-- _Summarize the changes_ -->

### Which issue(s) this PR fixes:
<!-- _Link to github issue(s)_ -->

### What issues does this PR fix or reference?
### PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

> - Open new test/doc issues under the [devfile/api](https://github.com/devfile/api/issues) repo
> - Check each criteria if:
> - There is a separate tracking issue. Add the issue link under the criteria
> **or**
> - test/doc updates are made as part of this PR
> - If unchecked, explain why it's not needed

### Is your PR tested? Consider putting some instruction how to test your changes

- [ ] Unit/Functional tests

<!-- _These are run as part of the PR workflow, ensure they are updated_ -->

- [ ] [QE Integration test](https://github.com/devfile/integration-tests)

<!-- _Do we need to verify integration with ODO and Openshift console?_ -->

- [ ] Documentation

<!-- _This includes product docs and READMEs._ -->

- [ ] Client Impact

<!-- _Do we have anything that can break our clients? If so, open a notifying issue_ -->


### How to test changes / Special notes to the reviewer: