Only track fresh starts of workspaces in workspace started metrics #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
amisevsk
reviewed
Nov 24, 2021
| } | ||
|
|
||
| func CurrentTime() string { | ||
| return strconv.FormatInt(time.Now().UnixNano()/1e6, 10) |
There was a problem hiding this comment.
I know this is a rearrangement of what's already here, but it might make sense to do sometime line
Suggested change
| return strconv.FormatInt(time.Now().UnixNano()/1e6, 10) | |
| return strconv.Itoa(time.Now().UnixNano()/time.Millisecond) |
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
amisevsk
approved these changes
Dec 1, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Well done, this looks like a frustrating one to figure out 😄 |
|
/test v8-devworkspace-operator-e2e |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR makes it so that when an already running workspace is reconciled we don't count that as a workspace start in the metrics
What issues does this PR fix or reference?
#618
Is it tested? How?
oc apply -f samples/theia-next.yamlstarted: falsestarted: truePR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che