-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update devfile/api dependency to v2.2.1 #1186
chore: Update devfile/api dependency to v2.2.1 #1186
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
…er and kubernetes component Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
1608bff
to
bdac5e8
Compare
New changes are detected. LGTM label has been removed. |
/retest |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
+ Coverage 52.90% 53.10% +0.19%
==========================================
Files 84 84
Lines 7551 7551
==========================================
+ Hits 3995 4010 +15
+ Misses 3273 3259 -14
+ Partials 283 282 -1 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Updates the devfile/api dependency to the v2.2.1 (commit devfile/api@1ae41b5). This is required for #1179, as the devfile validation library was previously preventing a deworkspace from having a container component and openshift/kubernetes component from using the same target port on an endpoint.
I also added a controller env test to test the case from #1179, but this might be redundant as this functionality should already be tested in the devfile API repo.
What issues does this PR fix or reference?
#1179
Is it tested? How?
Install DWO with the changes from this PR, and create a devworkspace with a container component and kubernetes (or openshift) component that uses the same endpoint target port, such as the following:
Ensure the workspace starts up as expected. You should see a pod get deployed to the
devworkspace-controller
namespace calledwebserver-dwo-deployed
. The main thing to ensure is the workspace does not fail to startup with the following reason:* devfile contains multiple containers with same endpoint targetPort: 8080
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with CheSigned-off-by: Andrew Obuchowicz aobuchow@redhat.com