Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for devfile API events.preStop #1139

Closed
AObuchow opened this issue Jun 29, 2023 · 1 comment · Fixed by #1168
Closed

Support for devfile API events.preStop #1139

AObuchow opened this issue Jun 29, 2023 · 1 comment · Fixed by #1168
Assignees
@AObuchow
Labels
enhancement New feature or request
Milestone
v0.24.0

Comments

@AObuchow
Copy link
Collaborator

Description

Currently, events.preStop from the devfile API is not supported by DWO.

Support for multiple preStop events should be added to DWO.

When this is implemented, it should not conflict with the async storage's preStop event hook.

Additional context

This is a precursor to eclipse-che/che#22308, see eclipse-che/che#22308 (comment)
@AObuchow AObuchow added the enhancement New feature or request label Jun 29, 2023
@AObuchow AObuchow self-assigned this Jun 29, 2023
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Aug 22, 2023
@AObuchow
feat:: Support events.preStop
c036367 
Fix devfile#1139

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Aug 22, 2023
@AObuchow
feat: Support events.preStop
8e6c1b8 
Fix devfile#1139

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow mentioned this issue Aug 23, 2023
Merged
3 tasks
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Aug 30, 2023
@AObuchow
feat: Support events.preStop
041c893 
Fix devfile#1139

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@l0rd
Copy link
Collaborator

l0rd commented Sep 27, 2023 •
edited
Loading

Blocked by failing PR check tests that should be fixed as part of this issue

AObuchow added a commit that referenced this issue Oct 12, 2023
@AObuchow
feat: Support events.preStop
1e05ea4 
Fix #1139

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow added this to the v0.24.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AObuchow AObuchow

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging a pull request may close this issue.

Support events.preStop AObuchow/devworkspace-operator
2 participants
@l0rd @AObuchow