Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add needs-triage workflow #1199

Closed
wants to merge 6 commits into from
Closed

add needs-triage workflow #1199

wants to merge 6 commits into from

Conversation

yangcao77
Copy link
Contributor

What does this PR do?

This PR adds a workflow to always add needs-triage label to new/reopen issues.

copied over from odo's repo: https://github.com/redhat-developer/odo/blob/bc168518d169f2975040ba29dae2b334ebfddbb5/.github/workflows/issue-management.yaml#L17C1-L31C48

Which issue(s) does this PR fix

a to-do thing to adopt the new team operation process: https://docs.google.com/document/d/1IkujxkkrqdnXjmITGAIOCdAb4kH_ql_KexlWSpc8vEA/edit#heading=h.57d81ski9zgr

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming no issues with using label

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, johnmcollier, yangcao77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.75%. Comparing base (b4fea57) to head (945ae74).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1199   +/-   ##
=======================================
  Coverage   35.75%   35.75%           
=======================================
  Files          52       52           
  Lines        6696     6696           
=======================================
  Hits         2394     2394           
  Misses       4158     4158           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-valdron
Copy link
Member

@yangcao77 We are no longer using the needs-triage label anymore, should we close this PR?

Copy link

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added lifecycle/stale Stale items. These items have not been updated for 90 days. and removed lifecycle/stale Stale items. These items have not been updated for 90 days. labels Feb 24, 2024
@yangcao77 yangcao77 closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants