Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish registry operator release images #1267

Closed
3 tasks done
Tracked by #410
johnmcollier opened this issue Sep 26, 2023 · 13 comments · Fixed by devfile/registry-operator#56 or openshift/release#44995
Closed
3 tasks done
Tracked by #410
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/task severity/blocker Issues that prevent developers from working

Comments

@johnmcollier
Copy link
Member

johnmcollier commented Sep 26, 2023

Which area/kind this issue is related to?

/area registry
/kind task

Issue Description

When a new version of the registry operator is published, GitHub Actions workflows should run which automatically publish the release images to Quay.io.

It’s possible to get the release tag when a GitHub Action runs upon the creation of a new release, so it should be a straightforward to tag the image in Quay.io

Guide to creating release workflows: https://birtony.medium.com/setting-up-automated-release-workflow-with-github-actions-628dbca2446e

Release Workflow Trigger Example

on:
  push:
    # Sequence of patterns matched against refs/tags
    tags:
      - '[0-9]+.[0-9]+.[0-9]+'

Acceptance Criteria

  • Create a workflow file that triggers on release cuts
  • Create tasks to build and push quay.io/devfile/registry-operator and quay.io/devfile/registry-operator-bundle on the release changes, use version label as tag
  • Perform integration testing on release images

Revised by (2023-10-12): @michael-valdron

@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Sep 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

@johnmcollier: The label(s) kind/task cannot be applied, because the repository doesn't have them.

In response to this:

Which area/kind this issue is related to?

/area registry
/kind task

Issue Description

When a new version of the registry operator is published, GitHub Actions workflows should run which automatically publish the release images to Quay.io.

It’s possible to get the release tag when a GitHub Action runs upon the creation of a new release, so it should be a straightforward to tag the image in Quay.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnmcollier
Copy link
Member Author

/kind task

@michael-valdron
Copy link
Member

Adding as part of #410.

@michael-valdron
Copy link
Member

Blocker to #1194: #410 (comment)

@michael-valdron michael-valdron added the severity/blocker Issues that prevent developers from working label Oct 18, 2023
@michael-valdron
Copy link
Member

Starting point for .goreleaser.yaml, publishes release and snapshot/release images. Investigating generating a changelog that contains PRs instead of commits.

@michael-valdron
Copy link
Member

Starting point for .goreleaser.yaml, publishes release and snapshot/release images. Investigating generating a changelog that contains PRs instead of commits.

Setting use: github-native solves the above:

changelog:
  use: github-native

Release result

Image

@michael-valdron
Copy link
Member

michael-valdron commented Oct 20, 2023

Release workflow completed for release image pushing.

@michael-valdron
Copy link
Member

Release workflow completed for release image pushing.

Testing of the release workflow was successful, got triggered and had successful runs on tags v0.1.4 and v0.1.4-rc.1 but did not trigger on v0.1.4-rc.a which does not use the release version format.

Screenshot from 2023-10-23 16-07-32

Screenshot from 2023-10-23 16-08-05

@michael-valdron
Copy link
Member

michael-valdron commented Oct 31, 2023

devfile/registry-operator#56 adds the GH actions needed for this process, still need to resolve implementing OpenShift CI release testing (openshift/release#44995) to close this issue, reopening..

@michael-valdron
Copy link
Member

michael-valdron commented Nov 3, 2023

Based on revisions to the release process, #1194 (comment), a refactor to the release workflow is needed.

version-check and k8s-integration-test should be moved into a separate workflow that is triggered on PRs targeting release branches. The changes to openshift/release#44995 should be revised to target existing release branches, if a new release branch is added then a change is needed to openshift/release to target that branch.

@michael-valdron
Copy link
Member

Based on revisions to the release process, #1194 (comment), a refactor to the release workflow is needed.

version-check and k8s-integration-test should be moved into a separate workflow that is triggered on PRs targeting release branches. The changes to openshift/release#44995 should be revised to target existing release branches, if a new release branch is added then a change is needed to openshift/release to target that branch.

PR for GitHub workflow revisions ready for review: devfile/registry-operator#57

@michael-valdron
Copy link
Member

michael-valdron commented Nov 6, 2023

Based on revisions to the release process, #1194 (comment), a refactor to the release workflow is needed.
version-check and k8s-integration-test should be moved into a separate workflow that is triggered on PRs targeting release branches. The changes to openshift/release#44995 should be revised to target existing release branches, if a new release branch is added then a change is needed to openshift/release to target that branch.

PR for GitHub workflow revisions ready for review: devfile/registry-operator#57

PR for OpenShift CI prow job revisions ready for review: openshift/release#44995

@michael-valdron
Copy link
Member

devfile/registry-operator#57 & openshift/release#44995 have been merged, resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/task severity/blocker Issues that prevent developers from working
Projects
Status: Done ✅
2 participants