Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-library): textarea label space alignment and counter alignment #907

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix(ui-library): textarea label space alignment and counter alignment #907

merged 3 commits into from
Feb 14, 2024

Conversation

RubirajAccenture
Copy link
Contributor

No description provided.

davidken91
davidken91 reviewed Feb 13, 2024
View reviewed changes
packages/ui-library/src/components/forms/textarea/index.css.ts
@@ -73,7 +76,6 @@ export const { tokenizedLight: textAreaLight, tokenizedDark: textAreaDark } = re
max-width: 100%;
word-break: break-all;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the background colour of white here like the ticket says? Something like this maybe? background-color: ${SurfaceFill.Default.Hover};

davidken91
davidken91 reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@davidken91 davidken91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 53 in the textarea.stories.ts file, you can replace errorIcon: 'blr360 with errorIcon: ''. This will resolve another one of the acceptance criteria of the ticket. Then you can remove the unused // @ts-expect-error todo on line 456

@davidken91
Copy link
Contributor

Also, I can't seem to recreate this issue on the develop branch: Currently in code the spacing between input and label is there, even if the hasLabel=false. In design this spacing is not there. Maybe we need to align with Lars or Thorben on this

@RubirajAccenture RubirajAccenture force-pushed the fix/822/textarea-fixes branch 2 times, most recently from 2315d12 to 054ce18 Compare February 13, 2024 14:48
davidken91
davidken91 previously approved these changes Feb 13, 2024
View reviewed changes
remmycat
remmycat reviewed Feb 13, 2024
View reviewed changes
packages/ui-library/src/components/forms/textarea/index.ts Outdated Show resolved Hide resolved
packages/ui-library/src/components/forms/textarea/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@RubirajAccenture RubirajAccenture force-pushed the fix/822/textarea-fixes branch 2 times, most recently from 32febc8 to 0efe38f Compare February 14, 2024 09:51
@RubirajAccenture RubirajAccenture merged commit 209ad72 into develop Feb 14, 2024
3 of 4 checks passed
@RubirajAccenture RubirajAccenture deleted the fix/822/textarea-fixes branch February 14, 2024 10:28
larserbach pushed a commit that referenced this pull request Feb 19, 2024
@RubirajAccenture @larserbach
fix(ui-library): textarea label space alignment and counter alignment (…
ec7bba4 
…#907)

* fix(882): textarea label space alignment and counter alignment

* yarn lock reverted
thrbnhrtmnn added a commit that referenced this pull request Feb 26, 2024
@thrbnhrtmnn @kaikdi
@ChristianHoffmannS2 @usmanreal1 @UsmanMuhammad @JpunktWpunkt @davidken91 @larserbach @m-nti @RubirajAccenture @bar-tay @seemann @angsherpa456 @remmycat @veilvokay
Release v0.2.0 (#961)
26930b2 
* feat(ui-library): add figma plugin to storybook (#703)

* added lit-analyzer to compile step and updated vs code extensions (#714)

* added lit-analyzer to compile step and updated vs code extensions

* updated lit and added github worklflow

* updated path

* pathes stuff

* github jobs renaming

* ignore analyze in the pipeline

* test the attribute

* removed comment

* dont update lit

* dont update lit

* fix lit-analyzer job (#721)

* NumberInput - Fix the disappearing stepper buttons and hiding placeholder text (#719)

* fix the numberinput to always display stepper

before, stepper would disappear if you set the unit
to undefined or readonly to true. this was because
of conditonal rendering conditions.
this fixes the problem by extracting the stepper
render function outside the rendering condition of
unit inside the input.

* display the placeholder for default value

the default value in not undefined, so it would hinder
and unable the placeholder to be visible.
this adds a condition to render the placeholder if it's not
the default value

* adds test for disappearing stepper buttons

---------

Co-authored-by: Muhammad Usman <bcs.12.16@gmail.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* fixing icon compile rimraf, fixing missing source icons and add lazy loading to icons and run test against build (#718)

* commit before passing

* got icons chunked

* fix eslint issue

* Delete doc/CONTRIBUTE.md (#727)

- deleting old contribute file, so a new one that is linked in the About section of the repo can be added

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Create CONTRIBUTING.md (#728)

Adding a new contribute file, which will also be displayed under about on the repo starting page

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Create CONTRIBUTING.md (#729)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Update README.md (#730)

fixed links to:
- contribution.md
- code of conduct md
- discussion board

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove duplicate of contribution.md (#731)

Removing the duplicate contribution.md file, as the correct file now is located outside of the doc folder. This change was done, to comply with the the GitHub Community Standards.

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update year in license (#732)

- Updated year in license.md to 2023-2024
- Also fixed an error, where B01LER was not replacing the full placeholder

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update label section in contribute file (#738)

Updated the labels under Tipps to find issues, and added the "core team issue" label, which was newly introduced.

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: fix storybook link in README (#744)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fixed missing token and missing word wrap behaviour (#759)

* feature/492-storybook-counter (#702)

* feat(storybook): added Counter Stories

---------

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>

* 545 form label rename tokens (#761)

* fix(tokens): moves and renames
label tokens are renamed to component name and moved into component sets

* feat: adds FormLabel to style-dictionary.config

* fix: apply renamed tokens to forms.css

* feat(tokens) moving label colors to CMP
forms.label.[state] stays in SEM but will not be applied onto component anymore

* fix: replaces Forms.Label with Forms.FormLabel
Also fixes LabelNextToControl colors in multiple files.

* fix(tokens): move nextToConrol from SEM to CMP
also renames to InlineLabel

* fix: fix occurances of labelNextToControl
This typotoken moved to CMP and was renamed to ..LabelInline.Typography.

* moved checkbox css changes to component css file and deleted global

* removed comma

* readded correct tokens to checkbox

* fixed radio css file

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>

* 540 textarea rename tokens (#762)

* fix(tokens): renames textarea minHeight

* fix: apply new tokennames at Textarea css

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>

* Removed configuration (#768)

* feature/496-storybook-form-label (#686)

* feat(storybook): added form Label Story

* fix(storybook): added line break

* fix(storybook): changed some little text and stories after review

* fix(storybook): fixed some text changes after review

---------

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix/409-storybook-checkbox (#700)

* fix(storybook): added some changes after review

* fix(storybook): added changes after review

---------

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Fix example app icons (#724)

* we need a relative path here

* fix for range slider only

* fixed some imports and deactivated icon tests

* now all tests run against build

* prod fix of example app

* added dependencies to story for buttons (#786)

* added dependencies to story for buttons

* fix for all

* fixes icon keys (#788)

* icon uses correct event handling for blrClick - fixes password (#787)

* icon uses correct event handling for blrClick - fixes password

* compile issues

* feat: updates ItemSpacings to have different values per size (#769)

* feat: updates ItemSpacings to have different values per size

* remove configuration

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* docs: change readme picture (#795)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* move config file out of src (#648) (#684)

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* 413-radio group docs (#690)

* feat(storybook): initial commit

* feat(storybook): add radio group docs

* fix(ui): add feedback

* fix(storybook): change folder name

* fix(storybook): filenaming

* fix(storybook): import issues

* fix(storybook): import issue

---------

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* Feature/419 storybook toggle switch (#783)

* feat(storybook): added argTableTypes

* feature(storybook): added toggle-switch story

* feature(storybook): added various stories

* fix(storybook): added changes after review and add name property to component

* fix(storybook): change story property order

* fix(storybook): added changes after review

* fix(storybook): another changes after review

* fix(storybook): added changes after review

* #550 tooltip rename tokens 2 (#794)

* fixes tooltip tokens

* apply new token names on tooltip-bubble/index.css

* Adds tooltip elevation and typo tokens

* fix tooltip tokens

---------

Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* #544 slider rename tokens (#796)

* background color tokens

* renames slider tokens

* fix border tokens

* apply tokens on slider.legend.css

* update slider.css slider-legend.css range-slider-utils.ts

---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>

* #544 form caption rename tokens (#801)

* renames form caption tokens and moves them to CMP

* Defines semantic caption tokens

* adds CMP counter typo tokens

* fix Referencing UI.Caption for typo now

* Moves captionComponent css from form.css to captionComponent index.css
Renames tokens

* fix: tokens on counter component

* fix: rename tokens in radio.css
(We should check if caption tokens are really needed here)

* minor adjustment

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>

* feat(storybook): add divider docs (#694)

* feat(storybook): add divider docs

* fix: adds comma in $themes (#804)

* adds comma in $themes

* fix: regenerate themes.json

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>

* Fix/712 fix scrolling (#791)

* Implemented requestAnimationFrame to restore scroll position and focus

* fix(ui-library): fixed contrast violation in disabled state (#802)

* fix(ui-library): fixed contrast violation in disabled state for icon-button and text-button and fixed that the text can not be selected in disabled mode for different browsers
---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* feat(storybook): add button group docs (#806)

* feat(storybook): add button group docs

* fix(storybook): add feedback

* fix(storybook): delete labels and fix alignment

---------

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* feat(storybook): add icon docs (#756)

* feat(ui): add icon docs

* feat(storybook): add icon docs file

* feat(storybook): add feedback

* fix(storybook): fix prop order

* fix(storybook): fix prop size

* fix(storybook): fix props

---------

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Code snipped fix (#814)

* render functions doesnt use dots and handles boolean

* solved!

* arrays/objects should work again but wont show in code snipped

* in case of boolean false, we have to give an excplicit false as property

* Select: html options instead of array (#780)

* feat(ui-library): replaced options array with slots in blrSelect component

---------

Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>
Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>

* feat(ui-library): fixing caption component styles (#818)

* Feature/513 tabbar use slots instead of arrays in the tabbar (#799)

* replacing array with slots in tabbar component

* fix number unit padding (#695)

* fix number unit padding

* refactored css

* code formatting

* cleanups

* full width

* split prepend case is done

* fixed non split versions

* turned on description again

* fixed paddings, readonly and story property namings

* updated branch

---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* #534 numberinput renames tokens (#785)

* renames numberinput.inputField.textWrapper.itemSpacing..

* updates ../number-input/index.css.ts

* reset css.ts

* token renamings

---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>

* Updates token meta (#820)

* minor

* feat(storybook): add tooltip docs (#716)

* feat(storybook): add tooltip bubble docs (#821)

* Fix/578 counter state (#826)

* fix(ui-library): renamed default to neutral

* Fix/597 form label (#827)

* fix(ui-library):fix label padding

---------

Co-authored-by: Barkley <barkley.taylor@accenture.com>
Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com>

* Documentation Form Caption Component (#717)

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* fix(ui-library): fixed checked state (#803)

Co-authored-by: manuel.seemann <manuel.seemann@amadqg9ywp2v0.fritz.box>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>

* #770 stepper rename tokens (#828)

* renames stepper tokens

* reasign divider container color

* renames stepper combo tokens

* renames commbo divider padding tokens

* updates stepper css2

* updates number input css & deletes foundation/.../action.css

* adds stepperButton backgound and icon color

* adds stepper icon size tokens

* minor

* updates border

* fix border token

* update css

* fix disabled

* mv tokens Action/Menu -> Actions/Menu (#839)

* updates menu tokens (#840)

* Fix/number input (#841)

* fix(ui-library): number input bug fixes

* Fix/772 dialog rename tokens (#842)

* renames dialog tokens

* add typo and textcolor to dialog

* minor

* fix error handling (#844)

* Renames tokens: Action -> Actions (#843)

* Tokens: replaces all Action/... with Actions/...

* fix css by replacing Action with Actions

* fix getComponentConfigToken params

* Fix/rename focused tokens (#847)

* renames focused -> focus

* minor

* fix css focused -> focus

* feat:Create SECURITY.md (#848)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feature/428-feedback-form (#846)

* feat:create bug_report.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update bug_report.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat:Delete .github/ISSUE_TEMPLATE/custom-bug-template.md

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat:Create feature_request.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Rename bug_report.yaml to 1_bug_report.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Rename feature_request.yaml to 2_feature_request.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat:Update and rename custom.md to 3_custom_issue.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat:Create config.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update config.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update 1_bug_report.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update 2_feature_request.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update 3_custom_issue.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat:Create SUPPORT.md

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Feature/428 fix feedback form (#850)

* fix:Rename config.yaml to config.yml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update 1_bug_report.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Fix/790 improve padding naming (#851)

* renames paddingTopBottom and paddingLeftRight tokens

* fix tooltip padding token

* fix css and other minor

* rmv token: Actions.BorderRadius

* fix menu...borderRadius

* minor

* Feat/845 improve token structure (#853)

* new config

* update config

* fix styledictionary.config

* Fix/597 form label padding (#855)

* feat(ui-library): adding label wrapper to each consuming component and applying padding

* Feature/366 getstarted documentation (#857)

* fix:Update 3_custom_issue.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update 3_custom_issue.yaml

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feature:Update GETSTARTED.md

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feature:Update GETSTARTED.md

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>

* fix:Update README.md (#861)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix/Update README.md (#862)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* feat(storybook): delete react folder (#836)

* feat(storybook): delete react folder

* fix(ui-library): centering tooltip bubble text (#856)

* docs:Update GETSTARTED.md (#882)

Added bullet about sales deck in project management checklist

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs:Update README.md (#888)

- fixed downloadlink to figma file
- removed issues & bugs section, as the new sections under help & feedback, which we added as part of #428 are way more detailed and have a better user-flow

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix: fixing readme file with updated figma file links (#889)

* added tooltip to example app and fixed offset (#837)

Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>

* fix(storybook): adjust component size (#881)

* fix(storybook): adjust component size

* fix(ui): change sm border width

---------

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(ui): add eventListeners to textarea (#485) (#885)

* docs:Update PROJECTBACKGROUND.md (#892)

* docs:Update PROJECTBACKGROUND.md

- filled out projectbackground template

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix:Update PROJECTBACKGROUND.md

fixed a typo

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(884): loading status property remocal from loader component (#887)

* Fix/form caption accessibility (#893)


* fix(ui-library): removing aria-label from form caption group

---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>

* docs:Update GETSTARTED.md (#900)

Added pre-refinement to meetings

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(ui): add eventListeners to textinput (#482) (#890)

* fix(ui-library): removing aria-label from form caption group

---------



docs:Update GETSTARTED.md (#900)

Added pre-refinement to meetings

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(all): use new name of lit-analyzer extension in vs code recommendations (#906)

* docs:Update README.md (#914)

added a missing word

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(ui): adjust naming in documentation of icon (#879) (#905)

* consistency property naming between code and documentation for divider (#874) (#896)

* fix(ui-library): textarea label space alignment and counter alignment (#907)

* fix(882): textarea label space alignment and counter alignment

* yarn lock reverted

* feature(storybook): change folder structure (#894)

* feature(storybook): change folder structure

* fix(storybook): change imports for types

* fix(storybook): wip

* only create custom element if not defined

* feat(storybook): align overall folder structure

* fix(storybook): tests

* fix(storybook): delete unnecessary folder

* fix(storybook): wip

* fix(storybook): delete double customElements

---------

Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>

* fix(storybook): clean up (#925)

* fix(ui-library): number input accessibility (#917)

* fix(ui-library): add aria labels to number input steppers

* fix(ui-library): render form labels and inputs in same shadow dom to preserve "for" relation

* fix(ui-library): set theme text color for number input and fix theme toggle

* fix:Update CONTRIBUTING.md (#863)

Added "fix" as a valid feature branch, as discussed today with the team.

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: Update GETSTARTED.md (#898)

Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>

* Feat/606 storybook badges (#930)

* feature(ui-library): added storybook badges addon and customized it

* docs(general):Update CONTRIBUTING.md (#934)

- changed title to "Contributing" and combined intro sections above "Content"
- added icons to main section titles and Content
- removed B01LER Monthly, as it is already mentioned in README

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* fix(ui): adjust naming in documentation of textarea (#485) (#885) (#895)

* feat(ui-library): rename change events and move event code to global file

* feat(ui-library): rename change events to prepare for exact types

* refactor(ui-library): move event code and types to global file

# Conflicts:
#	packages/ui-library/src/components/checkbox/index.ts
#	packages/ui-library/src/components/select/index.ts
#	packages/ui-library/src/components/text-input/index.ts
#	packages/ui-library/src/components/textarea/index.ts

* fix(documentation): create testing documentation (#371) (#928)

* fix(icons): auto generated icon type needs const array (#929)

* Fix/645 add unit tests for slots (#903)

* fix(ui-library): adding unit tests for components using slots

* fix(877): Ensure Consistency between Storybook Documentation and Codebase (#941)

* fix/866-ensure-consistency-property-names (#891)

* fix(ui-library): harmonized property naming in iconButton

* fix(781):Ensure Consistency between Storybook Documentation and Codebase Property Names (#939)

* Fix/867 ensure property naming text button (#935)

* fix(ui-library): harmonized property naming in textButton and all relevant files

* fix/867a-ensure-property-naming-text-button (#944)

* fix(ui-library): added some changes after review

* fix(ui-library): adapted action property naming in the story

* fix(ui-library): harmonized naming in argTypes

* fix(ui): fix textarea accessibility violation (#777) (#919)

* fix(ui-library): props alignment button group (#948)

* docs(fix): rename doc to docs (#951)

* - renamed doc folder to docs
- updated links between documentation files
- updated "Get Started" section in CONTRIBUTING file

* docs: fix typos

* docs: remove empty lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove empty lines and premature sentence wrapping

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: removing new line and sentence wrapping

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove new lines and sentence wrapping

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove new lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove new lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove new lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove new lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove empty lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: remove empty lines

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs(general):Update ARCHITECTURE.md file (#950)

* 735-update-renamed-repo-links (#955)

* docs(README): update image link

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update repo links

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update repo links

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update repo links

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update repo links

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update repo links

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* Feat/improve token structure v3 (#946)

* Feat(tokens): applied tokenchanges from v2

* updated tokens

* try fix tokens:generate on CI

* try fix tokens:generate on CI

* made gitignore not needing to know theme names

* try fix tokens:generate on CI

* try fix tokens:generate on CI

* all folders lower case

* fix number names

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>

* Feature/564 new figma release (#956)

* docs: update figma links for new release

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: update figma link

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

* docs: fix figma link (#957)

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>

---------

Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Co-authored-by: kaikdi <51678690+kaikdi@users.noreply.github.com>
Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Co-authored-by: Usman <90220070+usmanreal1@users.noreply.github.com>
Co-authored-by: Muhammad Usman <bcs.12.16@gmail.com>
Co-authored-by: JpunktWpunkt <92968754+JpunktWpunkt@users.noreply.github.com>
Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>
Co-authored-by: larserbach <larserbach@users.noreply.github.com>
Co-authored-by: m-nti <117906965+m-nti@users.noreply.github.com>
Co-authored-by: RubirajAccenture <122974571+RubirajAccenture@users.noreply.github.com>
Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com>
Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>
Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>
Co-authored-by: Barkley <barkley.taylor@accenture.com>
Co-authored-by: Manuel Seemann <manuel.seemann@accenture.com>
Co-authored-by: manuel.seemann <manuel.seemann@amadqg9ywp2v0.fritz.box>
Co-authored-by: Ang Dawa Sherpa <89925822+angsherpa456@users.noreply.github.com>
Co-authored-by: Remmy Cat Stock <3317423+remmycat@users.noreply.github.com>
Co-authored-by: Roman Yakovliev <54674847+veilvokay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidken91 davidken91 davidken91 approved these changes

@remmycat remmycat remmycat approved these changes

@JpunktWpunkt JpunktWpunkt Awaiting requested review from JpunktWpunkt

@bar-tay bar-tay Awaiting requested review from bar-tay

@ChristianHoffmannS2 ChristianHoffmannS2 Awaiting requested review from ChristianHoffmannS2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubirajAccenture @davidken91 @remmycat