-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): better build flow #902
Draft
ChristianHoffmannS2
wants to merge
83
commits into
develop
Choose a base branch
from
feat_all_better_build_flow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added lit-analyzer to compile step and updated vs code extensions * updated lit and added github worklflow * updated path * pathes stuff * github jobs renaming * ignore analyze in the pipeline * test the attribute * removed comment * dont update lit * dont update lit
…lder text (#719) * fix the numberinput to always display stepper before, stepper would disappear if you set the unit to undefined or readonly to true. this was because of conditonal rendering conditions. this fixes the problem by extracting the stepper render function outside the rendering condition of unit inside the input. * display the placeholder for default value the default value in not undefined, so it would hinder and unable the placeholder to be visible. this adds a condition to render the placeholder if it's not the default value * adds test for disappearing stepper buttons --------- Co-authored-by: Muhammad Usman <bcs.12.16@gmail.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
…loading to icons and run test against build (#718) * commit before passing * got icons chunked * fix eslint issue
- deleting old contribute file, so a new one that is linked in the About section of the repo can be added Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Adding a new contribute file, which will also be displayed under about on the repo starting page Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
fixed links to: - contribution.md - code of conduct md - discussion board Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Removing the duplicate contribution.md file, as the correct file now is located outside of the doc folder. This change was done, to comply with the the GitHub Community Standards. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
- Updated year in license.md to 2023-2024 - Also fixed an error, where B01LER was not replacing the full placeholder Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Updated the labels under Tipps to find issues, and added the "core team issue" label, which was newly introduced. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): added Counter Stories --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>
* fix(tokens): moves and renames label tokens are renamed to component name and moved into component sets * feat: adds FormLabel to style-dictionary.config * fix: apply renamed tokens to forms.css * feat(tokens) moving label colors to CMP forms.label.[state] stays in SEM but will not be applied onto component anymore * fix: replaces Forms.Label with Forms.FormLabel Also fixes LabelNextToControl colors in multiple files. * fix(tokens): move nextToConrol from SEM to CMP also renames to InlineLabel * fix: fix occurances of labelNextToControl This typotoken moved to CMP and was renamed to ..LabelInline.Typography. * moved checkbox css changes to component css file and deleted global * removed comma * readded correct tokens to checkbox * fixed radio css file --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* fix(tokens): renames textarea minHeight * fix: apply new tokennames at Textarea css --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* feat(storybook): added form Label Story * fix(storybook): added line break * fix(storybook): changed some little text and stories after review * fix(storybook): fixed some text changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* fix(storybook): added some changes after review * fix(storybook): added changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* we need a relative path here * fix for range slider only * fixed some imports and deactivated icon tests * now all tests run against build * prod fix of example app
* added dependencies to story for buttons * fix for all
* icon uses correct event handling for blrClick - fixes password * compile issues
* feat: updates ItemSpacings to have different values per size * remove configuration --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): initial commit * feat(storybook): add radio group docs * fix(ui): add feedback * fix(storybook): change folder name * fix(storybook): filenaming * fix(storybook): import issues * fix(storybook): import issue --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
* feat(storybook): added argTableTypes * feature(storybook): added toggle-switch story * feature(storybook): added various stories * fix(storybook): added changes after review and add name property to component * fix(storybook): change story property order * fix(storybook): added changes after review * fix(storybook): another changes after review * fix(storybook): added changes after review
* fixes tooltip tokens * apply new token names on tooltip-bubble/index.css * Adds tooltip elevation and typo tokens * fix tooltip tokens --------- Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
* Tokens: replaces all Action/... with Actions/... * fix css by replacing Action with Actions * fix getComponentConfigToken params
* renames focused -> focus * minor * fix css focused -> focus
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat:create bug_report.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update bug_report.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat:Delete .github/ISSUE_TEMPLATE/custom-bug-template.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat:Create feature_request.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Rename bug_report.yaml to 1_bug_report.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Rename feature_request.yaml to 2_feature_request.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat:Update and rename custom.md to 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat:Create config.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update config.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update 1_bug_report.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update 2_feature_request.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat:Create SUPPORT.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* fix:Rename config.yaml to config.yml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update 1_bug_report.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* renames paddingTopBottom and paddingLeftRight tokens * fix tooltip padding token * fix css and other minor * rmv token: Actions.BorderRadius * fix menu...borderRadius * minor
* new config * update config * fix styledictionary.config
* feat(ui-library): adding label wrapper to each consuming component and applying padding
* fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feature:Update GETSTARTED.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feature:Update GETSTARTED.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): delete react folder
Added bullet about sales deck in project management checklist Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
- fixed downloadlink to figma file - removed issues & bugs section, as the new sections under help & feedback, which we added as part of #428 are way more detailed and have a better user-flow Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com>
* fix(storybook): adjust component size * fix(ui): change sm border width --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* docs:Update PROJECTBACKGROUND.md - filled out projectbackground template Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix:Update PROJECTBACKGROUND.md fixed a typo Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* fix(ui-library): removing aria-label from form caption group --------- Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>
Added pre-refinement to meetings Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
5 tasks
ChristianHoffmannS2
changed the title
Feat(all): better build flow
feat(all): better build flow
Mar 8, 2024
ChristianHoffmannS2
force-pushed
the
develop
branch
2 times, most recently
from
March 26, 2024 13:22
358f467
to
99c0c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will introduces caching, dependency tree visualiser and other benefits to our build processes