Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-library): #1083 introduce property sanitizer #1127

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(ui-library): #1083 introduce property sanitizer #1127

wants to merge 1 commit into from

Conversation

faselbaum
Copy link
Collaborator

Closes #1083

@faselbaum faselbaum changed the title feat(ui-library): 1083 introduce property sanitizer feat(ui-library): #1083 introduce property sanitizer Jun 19, 2024
@faselbaum faselbaum force-pushed the feat/1083_property-sanitization branch 2 times, most recently from 1cc2d19 to 442cb4c Compare June 21, 2024 11:32
@faselbaum faselbaum force-pushed the feat/1083_property-sanitization branch from 442cb4c to a29641d Compare July 1, 2024 08:47
@ashk1996 ashk1996 force-pushed the feat/1083_property-sanitization branch from a29641d to c7b18ca Compare August 23, 2024 15:00
@ashk1996 ashk1996 added 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers 🦹 needs:reviewers (design) The issue or pull request needs additional design reviewers and removed 🦹 needs:reviewers (design) The issue or pull request needs additional design reviewers labels Aug 26, 2024
@ashk1996 ashk1996 force-pushed the feat/1083_property-sanitization branch from 5378200 to 8124dfa Compare August 26, 2024 11:17
@faselbaum @ashk1996
feat(ui-library): 1083 introduce property sanitizer
8949837 
fix(ui-library): update sanitizationcontroller using SignalHub

fix(ui-library): property initilisation and defaulting for text area

fix(ui-library): property initialization and deafulting for input field text

fix(ui-library): resolve conflicts

fix(ui-library): add comments to diable a rule

fix(ui-library): resolve conflicts
@ashk1996 ashk1996 force-pushed the feat/1083_property-sanitization branch from 8124dfa to 8949837 Compare August 26, 2024 11:21
bar-tay
bar-tay approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@bar-tay bar-tay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I just saw tho that the tickets says that at least 5 components should be updated.

@ashk1996 ashk1996 mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bar-tay bar-tay bar-tay approved these changes

@ChristianHoffmannS2 ChristianHoffmannS2 Awaiting requested review from ChristianHoffmannS2

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code quality: Improve consistency for property initialisation and defaulting
3 participants
@faselbaum @bar-tay @ashk1996