Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Caption - icon in sm is not center aligned #798

Closed
5 tasks
Tracked by #452
thrbnhrtmnn opened this issue Jan 17, 2024 · 1 comment · Fixed by #969
Closed
5 tasks
Tracked by #452

Form Caption - icon in sm is not center aligned #798

thrbnhrtmnn opened this issue Jan 17, 2024 · 1 comment · Fixed by #969
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jan 17, 2024

Description / User Story

The icon in the Form Caption SM seems to be a bit off in code when compared to design. It seems like the icon is not center aligned, but bottom right aligned in the wrapping 14x14 px container. The issue might also be there in other sizes, but not that recognizable.


Acceptance Criteria

  • The icon placement within its container within the Form Caption has been investigated
  • The icon has been adjusted so it is perfectly aligned with design
  • Property name "ignoreSize" has been changed to "fillParent" for all components
  • "fillParent" default should be true for icon component
  • "sizeVariant" prop should only be displayed in prop panel of icon component in Storybook, if fillParent=false

Background information

  • Add relevant information here
  • ...
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Jan 17, 2024
@thrbnhrtmnn thrbnhrtmnn added ⭕ core team issue This is for the core team and should not be done by contributors and removed 💚 contributor issue Good for contributors labels Feb 1, 2024
@angsherpa456 angsherpa456 self-assigned this Feb 1, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Form Caption - icon in sm is too big Form Caption - icon in sm is not center aligned Feb 2, 2024
@larserbach
Copy link
Contributor

I took a look. (on Render with Firefox) The vertical alignment is correct in all size variants.
The technical solution differs from the design solution. There is no wrapper for the icon created, the padding is applied on the icon directly. Yet the visual result is the same as in design, therefor the ticket can be closed from my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants