Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox - component should be able to receive focus when in readonly state #752

Closed
Tracked by #452
thrbnhrtmnn opened this issue Jan 9, 2024 · 0 comments · Fixed by #1148
Closed
Tracked by #452

Checkbox - component should be able to receive focus when in readonly state #752

thrbnhrtmnn opened this issue Jan 9, 2024 · 0 comments · Fixed by #1148
Assignees
@ashk1996
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working 📋 task::ready Task is ready to be picked up or planned in
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

Step-by-Step Guide to reproduce

  1. Open checkbox in storybook
  2. Change component to readonly state
  3. Tab into component to focus it
  4. No focus ring is applied / focusing the component is not possible

Bug Description / False Behaviour

It is not possible to focus the Checkbox component in readonly state.

Correct Behaviour

It is possible to focus the Checkbox component in readonly state.

Testing

Check existing unit tests of the component(s) and adjust the tests to prevent this bug from occurring again in the future, if you see a way.

Background

Add more background information here, if needed
@thrbnhrtmnn thrbnhrtmnn added 🚨 new::bug Something isn't working ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Jan 9, 2024
This was referenced Jan 9, 2024
Open
Closed
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Mar 28, 2024
@ashk1996 ashk1996 self-assigned this Aug 12, 2024
@ashk1996 ashk1996 mentioned this issue Aug 26, 2024
Merged
@thrbnhrtmnn thrbnhrtmnn linked a pull request Aug 26, 2024 that will close this issue
fix(ui-library): checkbox component fixes #1148
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashk1996 ashk1996

Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

Successfully merging a pull request may close this issue.

fix(ui-library): checkbox component fixes deven-org/boiler
2 participants
@thrbnhrtmnn @ashk1996