Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox - fix misalignments/errors #599

Closed
14 of 16 tasks
Tracked by #452
thrbnhrtmnn opened this issue Nov 15, 2023 · 1 comment
Closed
14 of 16 tasks
Tracked by #452

Checkbox - fix misalignments/errors #599

thrbnhrtmnn opened this issue Nov 15, 2023 · 1 comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 15, 2023

Description / User Story

The following differences were found when comparing the Checkbox in Storybook with the Checkbox in Design:

Label:

  • Font Color for default and readonly state in light mode is wrong, currently it is hsl220 instead of hsl216 like in design > it is now always #17191c
  • Font Color for disabled state is wrong in light and dark mode, currently it is hsl220 instead of hsl212 like in design for light mode and hsl220 instead of hsl219 like in design for dark mode > it is now c7cad1 in light and #5c6370 in dark mode
  • Font Color for error state is wrong in light and dark mode, currently it is black (hsl220) instead of red (hsl350) like in design

Control:

Behaviour:

  • Readonly state is not working, input is still possible

Acceptance Criteria


Background information

  • Other things found in the checkbox:
    • There is an area between the control and the label where neither the hover nor pressed state get applied and it is not possible to check/uncheck the component. Is this intended by design? > fixed
    • The focus state initially only has a 1px border, which gets corrected to 2px after a short delay, also I assume the color in dark mode will be fixed with Focus State - global improvement #330 > fixed
    • Should the component not be clickable anymore, when it has an error state? > fixed
@thrbnhrtmnn thrbnhrtmnn added 🦹 needs:help Extra attention is needed 🚨 new::bug Something isn't working labels Nov 15, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title Checkbox - fix label font color Checkbox - fix misalignments/errors Nov 15, 2023
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers and removed 🦹 needs:help Extra attention is needed labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn
Copy link
Contributor Author

All ACs are already fixed or are part of other tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant