Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabBar - rename tokens #551

Closed
3 tasks done
Tracked by #692
, #552
...
thrbnhrtmnn opened this issue Nov 6, 2023 · 2 comments
Closed
3 tasks done
Tracked by #692
, #552
...

TabBar - rename tokens #551

thrbnhrtmnn opened this issue Nov 6, 2023 · 2 comments
Assignees
@ChristianHoffmannS2
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Milestone
Rename Component ...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 6, 2023 •
edited
Loading

Description / User Story

After changing the structure of the component tokens within #239 , we now need to adjust the token names for the TabBar.

Requirements

Acceptance Criteria

  • Design: All tokens used in the TabBar are following the new token naming
  • Dev: All tokens used in the TabBar are following the new token naming

Background information

  • Link to new token naming documentation
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Nov 6, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Nov 6, 2023
Closed
27 tasks
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Nov 9, 2023
@larserbach
Copy link
Contributor

larserbach commented Nov 23, 2023 •
edited
Loading

@ChristianHoffmannS2 Tokens are renamed and applied. Some additonal things are fixed.
Please take over here e.g move the css into the index.css.ts
branch: 511-tabbar-rename-tokens

@thrbnhrtmnn thrbnhrtmnn added 📋 task::planned 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers and removed 📋 task::ready Task is ready to be picked up or planned in labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Dec 12, 2023
Open
8 tasks
@larserbach
Copy link
Contributor

larserbach commented Dec 13, 2023 •
edited
Loading

@thrbnhrtmnn
The tabbar renaming is done and merged with the following issues:

  • Pressed state of tabs is not properly working, possible conflicting with focus state
  • Resizing behaviour is not following the design
  • Highlight line is not visible, needs to be fixed
  • Tabbar is only rendering a label, but we need to be able to reach in content for each tab
  • The tabbar is utilizing an array, but should use children / slots

@thrbnhrtmnn thrbnhrtmnn mentioned this issue Dec 18, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianHoffmannS2 ChristianHoffmannS2

Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Milestone
Rename Component Tokens
Development

No branches or pull requests
3 participants
@larserbach @ChristianHoffmannS2 @thrbnhrtmnn