Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabBar - use slots instead of arrays in the Tabbar #513

Closed
1 of 2 tasks
Tracked by #516 ...
thrbnhrtmnn opened this issue Oct 30, 2023 · 0 comments · Fixed by #799
Closed
1 of 2 tasks
Tracked by #516 ...

TabBar - use slots instead of arrays in the Tabbar #513

thrbnhrtmnn opened this issue Oct 30, 2023 · 0 comments · Fixed by #799
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 30, 2023

Description / User Story

The TabBar should use slots instead of arrays, similar to ButtonGroup or FormCaptionGroup.

One possible and the currently preferred way to do this would also be to introduce a new Tab component, which like the Radio is just a part of the parent Group component and would never be user as a standalone component. In design we already have a Tab component on the page of the TabBar (also exactly like the Radio on the RadioGroup page).


Acceptance Criteria

  • The TabBar uses slots instead of an array
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color > ask @angelicahoyss or @thrbnhrtmnn for support here

Background information

@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 30, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Nov 9, 2023
3 tasks
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title TabBar - create internal component for Tab and use slots in the Tabbar TabBar - use slots instead of arrays in the Tabbar Jan 8, 2024
@thrbnhrtmnn thrbnhrtmnn removed the 🎨 design issue Task is for designers label Jan 8, 2024
@davidken91 davidken91 self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants