Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton & IconButton - add missing events #486

Closed
3 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Oct 19, 2023 · 3 comments
Closed
3 tasks done
Tracked by #452

TextButton & IconButton - add missing events #486

thrbnhrtmnn opened this issue Oct 19, 2023 · 3 comments
Assignees
@kaikdi @ChristianHoffmannS2
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 19, 2023 •
edited
Loading

Description / User Story

Missing events of the need to be added to the TextButton, IconButton.

Acceptance Criteria

  • onFocus has been added
  • More events that are typically needed for these components have been added
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss cab support here

Background information

  • Link to props documentation (consider All Props page & Component page)
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 19, 2023
This was referenced Oct 19, 2023
Open
Closed
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Nov 9, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title TextButton, IconButton, ButtonGroup - add missing events TextButton, IconButton - add missing events Nov 14, 2023
@kaikdi kaikdi self-assigned this Nov 20, 2023
kaikdi added a commit that referenced this issue Nov 20, 2023
@kaikdi
fix(ui-library): add missing events from icon/text buttons (#486)
45e74e4
@kaikdi kaikdi mentioned this issue Nov 20, 2023
Closed
kaikdi added a commit that referenced this issue Nov 21, 2023
@kaikdi
fix(ui-library): add missing events from icon/text buttons (#486)
cc93252
kaikdi added a commit that referenced this issue Nov 21, 2023
@kaikdi
fix(ui-library): add missing events from icon/text buttons (#486)
0d53127
@thrbnhrtmnn thrbnhrtmnn changed the title TextButton, IconButton - add missing events TextButton & IconButton - add missing events Nov 22, 2023
kaikdi added a commit that referenced this issue Nov 22, 2023
@kaikdi
fix(ui-library): add missing events from icon/text buttons (#486)
d3819d8
@thrbnhrtmnn
Copy link
Contributor Author

This is also needed for the example applications

@thrbnhrtmnn thrbnhrtmnn added 📋 task::planned ⌨️ dev issue Task is for developers and removed 📋 task::ready Task is ready to be picked up or planned in labels Dec 1, 2023
@thrbnhrtmnn
Copy link
Contributor Author

As discussed today with @ChristianHoffmannS2 , we have a technical solution but all events need to be refactored again with the new approach.

This task will be moved to the backlog and we will refine it again to 1. decide which events we need for the beta release and 2. to then use the new approach to add all of these events (this also affects all the other issues to add missing events).

@thrbnhrtmnn thrbnhrtmnn added 📋 task::ready Task is ready to be picked up or planned in and removed 📋 task::planned labels Dec 7, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the Align & Fix First 15 Components milestone Jan 5, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Already implemented with #643

@thrbnhrtmnn thrbnhrtmnn removed the 📋 task::ready Task is ready to be picked up or planned in label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaikdi kaikdi

@ChristianHoffmannS2 ChristianHoffmannS2

Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaikdi @ChristianHoffmannS2 @thrbnhrtmnn