Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberInput - fix height issue #449

Closed
2 tasks done
Tracked by #452
larserbach opened this issue Oct 16, 2023 · 3 comments
Closed
2 tasks done
Tracked by #452

NumberInput - fix height issue #449

larserbach opened this issue Oct 16, 2023 · 3 comments
Assignees
Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working

Comments

@larserbach
Copy link
Contributor

larserbach commented Oct 16, 2023

I found two issues:

  • The height of the number input does not match exactly the height of the designed component. We need to investigate where the difference comes from and how to align the coded comps to design
  • The height changes, if the (stepper)-mode changes. mode 1 and 2 have the same height, mode 3 is different but shouldn't
@larserbach larserbach added the 🚨 new::bug Something isn't working label Oct 16, 2023
@kaikdi kaikdi self-assigned this Oct 17, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title NumberInput Height issue NumberInput - Height issue Oct 17, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title NumberInput - Height issue NumberInput - fix height issue Oct 18, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 19, 2023
@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 24, 2023

We had a look at todays review & merge session, here are the findings:

  • Height in MD is correct
  • Icon Button size is now wrong, which seems to be an issue with the container, the icons are correct.
  • Height in SM & LG mode3 is still 1px higher than it should

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 26, 2023

We had a look at todays review & merge session, here are the findings:

  • Height is correct in all modes
  • Mode 1 Stepper button should be square (ie. 48 px wide and 48 px high for the LG variant: Action.StepperCombo.LG.Vertical.Width")

@thrbnhrtmnn
Copy link
Contributor

After todays review and merge session no more open points where found, the issue can be closed as done, once it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants