Update global text and field styles #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added base font color with opacity variations. Implemented throughout with letter spacing. This is a WIP - this should be centralized rather than continuously repeated. I've been unable to get react-native-global-props to function.
sethvincent
reviewed
Jun 18, 2019
Taking care of this in separate PRs |
Also remove StyledText component from Variables. Investigate - remove styled.Text RN component from components where declared with no styles? Can also then remove styled-components import
LanesGood
changed the title
|
Debugging on ios now and there are some small layout issues around |
|
@sethvincent @kamicut I've set this PR as ready to review, as its gotten a bit large and away from the original stated purpose. I'll work on validation separately, and some of the rest of the app styling separately as well. This does still need to be tested and debugged on IOS. |
…ntseed/observe into update/field-styles-validation
|
tested and made some improvements for ios/iphonex layout of the tag editor and |
sethvincent
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple styling edits for text and field styles. This is an attempt to match the text and colors used throughout the app more closely to the original UI designs.
@sethvincent can you help out with some of the todos below, especially the first and last item?
TO DO:
-[ ] Implement working icons in FeatureDetailHeader for the View and Add point screens