Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep polygons closed #302

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Keep polygons closed #302

merged 4 commits into from
Jun 9, 2020

Conversation

geohacker
Copy link
Member

Fixes #301 and also fixes a bug where the node index goes out of order when a node is removed.

@geohacker geohacker requested a review from sethvincent June 5, 2020 12:03
@sethvincent
Copy link
Contributor

I tried testing deleting the first/last node and the style didn't update the same way the other nodes do, it just stayed the same. I looked at the ndrefs and coordinates on newWay and those seem to be changed in the expected way, it's just the style that doesn't change.

Things get wacky when I try to delete the first/last node again. Each time I try to delete the node after trying the first time it pushes a new item with the node id of the new first node into the ndrefs. I'm not sure exactly why yet, but if I try to delete first/last node multiple times, theres a whitespace error when submitting the changelog:

Error: Non-whitespace before first tag.
Line: 0
Column: 1

@geohacker geohacker force-pushed the fix/keep-polygons-closed branch from 3f41054 to 088d189 Compare June 7, 2020 05:27
@geohacker
Copy link
Member Author

@sethvincent that was my fault, I was removing first last and additional nodes and also trying to close the way for any delete operation which was unnecessary. My latest commit should fix the behaviour you are seeing.

@geohacker geohacker merged commit 386ec52 into edit-ways Jun 9, 2020
@geohacker geohacker deleted the fix/keep-polygons-closed branch June 9, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants