show way conflict message #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geohacker
reviewed
Jun 8, 2020
app/components/Conflict.js
Outdated
| @@ -217,6 +228,9 @@ export default class Conflict extends React.Component { | |||
| if (updatedFeature.isDeleted) { | |||
| return this.upstreamDeleted() | |||
| } | |||
| if (updatedFeature.geometry.type === 'LineString' || updatedFeature.geometry.type === 'Polygon') { | |||
There was a problem hiding this comment.
I think we should check if this is a complex edit and then disallow overwriting. The current condition will stop the user from overwriting attribute changes.
There was a problem hiding this comment.
I'm not sure actually. Perhaps this is ok for now.
geohacker
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make it so that conflicts on way changes can't be overwritten.
todo: