Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pending node dependencies #282

Merged
merged 8 commits into from
Jun 3, 2020
Merged

Handle pending node dependencies #282

merged 8 commits into from
Jun 3, 2020

Conversation

geohacker
Copy link
Member

Fixes #264

@geohacker geohacker requested a review from batpad June 1, 2020 09:32
@geohacker geohacker marked this pull request as ready for review June 2, 2020 11:27
@geohacker geohacker mentioned this pull request Jun 2, 2020
Closed
5 tasks
@geohacker geohacker requested a review from sethvincent June 2, 2020 15:46
@sethvincent
Copy link
Contributor

Did some testing of this and I think it's looking good.

How I tested:

  • turned off wifi
  • added and edited ways
  • added ways that shared a node with another way
  • turned on wifi and uploaded changesets

Sometimes when editing a way the style didn't seem to update correctly, but i think it was just the off by one error that we've already identified.

@geohacker geohacker merged commit 79f759d into edit-ways Jun 3, 2020
@geohacker geohacker deleted the pending-node-deps branch June 3, 2020 04:37
@geohacker geohacker mentioned this pull request Jun 5, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvincent sethvincent sethvincent approved these changes

@batpad batpad Awaiting requested review from batpad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geohacker @sethvincent