Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GeoJSON geometry when tag suggests area feature #227

Merged
merged 2 commits into from
May 19, 2020

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented May 19, 2020

See #128.

@geohacker I suggest testing with preset "Apartment Complex".

@vgeorge vgeorge requested a review from geohacker May 19, 2020 12:45
app/screens/Features/AddFeatureDetail.js Outdated Show resolved Hide resolved
app/utils/oms-tag-suggesting-area.js Outdated Show resolved Hide resolved
@vgeorge vgeorge requested a review from geohacker May 19, 2020 14:42
@geohacker
Copy link
Member

@vgeorge this looks great, thank you! One thing we should probably confirm: when a feature is considered to be an area, do we now add the area=yes tag? Does iD do that? If it does, we should add that to the properties.

@vgeorge
Copy link
Member Author

vgeorge commented May 19, 2020

@geohacker, we don't. I did two tests in iD: added a feature by selecting "Area" button at the top and selected a "area" preset on a closed way, none of them added area=yes. If I apply this tag manually to a feature in iD, it will be rendered differently, but presets doesn't seem to change it. It seems it uses area=* exclusively for rendering purposes.

@vgeorge vgeorge merged commit b456342 into edit-ways May 19, 2020
@vgeorge vgeorge deleted the enhance/change-geometry-type-from-tags branch May 19, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants