Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add starter presets for ways #220

Merged
merged 3 commits into from
May 13, 2020
Merged

Add starter presets for ways #220

merged 3 commits into from
May 13, 2020

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented May 13, 2020

See #208.

Changes:

  • Fix editWayEnter regression for new ways (based on Fix "add way" regression #219)
  • Changes SelectFeatureType component to use starter-presets.json when edit mode is for ways
  • Add presets for line features, based on the most popular on taginfo: highway, waterway/stream, barrier/fence, barrier/wall

@vgeorge vgeorge requested a review from geohacker May 13, 2020 12:04
geohacker
geohacker approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@geohacker geohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me, thank you @vgeorge.

@vgeorge vgeorge merged commit 04abdb4 into edit-ways May 13, 2020
@vgeorge vgeorge deleted the enhance/starter-presets branch May 13, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geohacker geohacker geohacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgeorge @geohacker