-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field inputs for ways #215
Conversation
I added a commit that adds the onewayCheck field and that gives the access field some needed styles (it's really a field group), and also makes some revisions so that the access field works properly. I realized that the restriction field/tag is something that is set on relations. I'm guessing that for now we're not working with relations in this editor. |
Did some more testing with this today, fixed some bugs that came up when merging the edit-ways branch, and I think it's ready to review. I believe I've tested all of these fields, though it's hard to say if I've tried every possible permutation of them. To recap, this pull request includes changes for these fields:
These remaining unsupported fields should be addressed in a later pull request:
|
@sethvincent I'm noticing something weird with the fields now. I'm not entirely sure if this is introduced in this branch. For example:
Apart from that, this PR looks and works great for me! Thank you. |
@geohacker thanks I'll look into that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inherited presets is a really good catch @sethvincent. This is looking really good to me.
Based on our current fields.json in the edit-ways branch, the unsupported fields right now are:
Not all of these are related to editing ways, and this PR will focus on those that are needed for ways.
included in this pull request
so far i've been working on:
should be saved for another pull request