Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field inputs for ways #215

Merged
merged 5 commits into from
May 13, 2020
Merged

Field inputs for ways #215

merged 5 commits into from
May 13, 2020

Conversation

sethvincent
Copy link
Contributor

@sethvincent sethvincent commented May 6, 2020

Based on our current fields.json in the edit-ways branch, the unsupported fields right now are:

  • access
  • radio
  • url
  • networkCombo
  • cycleway
  • email
  • tel
  • identifier
  • maxspeed
  • onewayCheck
  • restrictions
  • wikidata
  • structureRadio
  • wikipedia

Not all of these are related to editing ways, and this PR will focus on those that are needed for ways.

included in this pull request

so far i've been working on:

  • access
  • radio
  • cycleway
  • maxspeed
  • structureRadio
  • networkCombo
  • onewayCheck

should be saved for another pull request

  • identifier
  • wikidata
  • wikipedia
  • email
  • tel
  • url
  • restrictions (turn restrictions, added to relations)

@sethvincent
Copy link
Contributor Author

I added a commit that adds the onewayCheck field and that gives the access field some needed styles (it's really a field group), and also makes some revisions so that the access field works properly.

I realized that the restriction field/tag is something that is set on relations. I'm guessing that for now we're not working with relations in this editor.

@sethvincent sethvincent marked this pull request as ready for review May 11, 2020 23:38
@sethvincent
Copy link
Contributor Author

Did some more testing with this today, fixed some bugs that came up when merging the edit-ways branch, and I think it's ready to review.

I believe I've tested all of these fields, though it's hard to say if I've tried every possible permutation of them.

To recap, this pull request includes changes for these fields:

  • access
  • radio
  • cycleway
  • maxspeed
  • structureRadio
  • networkCombo
  • onewayCheck

These remaining unsupported fields should be addressed in a later pull request:

  • identifier
  • wikidata
  • wikipedia
  • email
  • tel
  • url
  • restrictions (turn restrictions, added to relations)

@geohacker
Copy link
Member

@sethvincent I'm noticing something weird with the fields now. I'm not entirely sure if this is introduced in this branch. For example:

  • Select a primary highway
  • Click edit attributes
  • Click add field

image

Apart from that, this PR looks and works great for me! Thank you.

@sethvincent
Copy link
Contributor Author

@geohacker thanks I'll look into that

Copy link
Member

@geohacker geohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inherited presets is a really good catch @sethvincent. This is looking really good to me.

@sethvincent sethvincent merged commit c9c4d4e into edit-ways May 13, 2020
@sethvincent sethvincent deleted the way-field-inputs branch May 13, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants