-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find nearest lines, edges, and nodes #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geohacker
requested review from
batpad and
sethvincent
and removed request for
batpad
April 27, 2020 12:31
…ce to store referecnes
sethvincent
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…rmediate states of all ways. fix minor state updates
…set only if a way is selected
…s-style Move selected features member nodes to state
…y on android the objects didn't clone. adjust styles
@sethvincent sorry, I just noticed you marked this for review but I merged it. It would make it easier for me to work on the add way mode and this branch has gotten too many things. Let me know if you'd like me to revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic util to find nearest lines, edges and nodes to a given node. When we draw and move nodes, these will help determine where we need to create intersections.
Todo:
cc @sethvincent @batpad