Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find nearest lines, edges, and nodes #209

Merged
merged 30 commits into from
May 8, 2020
Merged

Find nearest lines, edges, and nodes #209

merged 30 commits into from
May 8, 2020

Conversation

geohacker
Copy link
Member

@geohacker geohacker commented Apr 21, 2020

This PR introduces a basic util to find nearest lines, edges and nodes to a given node. When we draw and move nodes, these will help determine where we need to create intersections.

Todo:

  • Basic util to find edges and lines
  • Find the point on the line to create intersection
  • Find the node from the cache if there's an overlap/nearness

cc @sethvincent @batpad

@geohacker geohacker changed the base branch from develop to edit-ways April 21, 2020 14:56
@geohacker geohacker marked this pull request as ready for review April 27, 2020 12:17
@geohacker geohacker requested review from batpad and sethvincent and removed request for batpad April 27, 2020 12:31
Copy link
Contributor

@sethvincent sethvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sethvincent sethvincent self-requested a review May 7, 2020 16:35
@geohacker geohacker merged commit d64f423 into edit-ways May 8, 2020
@geohacker geohacker deleted the nearest branch May 8, 2020 10:51
@geohacker
Copy link
Member Author

@sethvincent sorry, I just noticed you marked this for review but I merged it. It would make it easier for me to work on the add way mode and this branch has gotten too many things. Let me know if you'd like me to revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants