Update presets

[geohacker]

This PR adds all presets from iD and updates existing ones along with their schema. This needs thorough testing. cc @developmentseed/observe

• Check map rendering and icons -- I think we might have to update te-maki + maki
• Check parent preset fetching and feature detail screens
• Check being able to search and add features

[LanesGood]

@geohacker in this same PR, can we add more presets on the initial "Select Feature Type" screen? This will help users see that there are multiple types available.

Will the parent preset types have a nested accordion/list style functionality, like in id?

[sethvincent]

From the limited testing I've been able to do this is working alright so far.

There are definitely bugs with the logic for determining a best guess at a preset, but I don't think that's new (and is definitely my fault). For example, there's no way this node in downtown seattle is what observe thinks it is:

[geohacker]

I just pushed a script to fetch and update icons. And fixed a bunch of tests that were failing because of unavailable icons, which are now resolved. This should be ready to merge, but needs another round of testing. @sethvincent @LanesGood @batpad

[geohacker]

The icons are bundled into iOS and Android for performance. This means apart from updating app/assets we have to symlink them to android/app/src/main/res and ios/Observe/Images.xcassets.

Android

It's as easy as creating a symlink:

• cd android/app/src/main/res/drawable-
• ln -s ~/observe/app/assets/temaki/*.png . - do this for maki and fontawesome

iOS

iOS is tricky because adding them via xcode makes direct copies instead of symlinks, and also adds them a 1x resolution. We want to add them as symlinks and 3x resolution. Looks like we'll have to write a script to do this. I had some luck using https://github.com/angelvasa/AVXCAssets-Generator, but it again creates a copy instead of symlinks and also changes the resolution. This means map icon sizes will become inconsistent between Android and iOS.

[geohacker]

So android is fixed now. For iOS I think we should write a script that generates Image.xcassets for each icon like https://github.com/developmentseed/observe/tree/develop/ios/Observe/Images.xcassets/fas_bacon.imageset.

@sethvincent I probably won't get to this today or tomorrow, so if you have time, it'll be great to wrap this up.

[sethvincent]

@geohacker I added the script for symlinking to android and ios. Did some testing on both to make sure images are still showing up alright and things are looking good.

[geohacker]

@sethvincent Thank you! I made some minor changes to the script to remove the asset folders and create it from scratch so we take out dead links. update-icons.sh not only adds but removes obsolete icons.

This is ready for merge I think. @LanesGood if you have sometime it'll be great if you test!

[LanesGood]

@geohacker @sethvincent both iOS and Android builds failing for me.

Main iOS error message:

The following build commands failed:

CompileAssetCatalog /Users/lane/Github/observe/ios/build/Observe/Build/Products/Debug-iphonesimulator/Observe.app /Users/lane/Github/observe/ios/Observe/Images.xcassets

Main Android error message:

Execution failed for task ':app:mergeDebugResources'.
> Could not list contents of '/Users/lane/Github/observe/android/app/src/main/res/drawable-xxhdpi/temaki_chairlift.png'. Couldn't follow symbolic link.

[sethvincent]

I revised the script to use relative paths and ran the script again to update the symlinks. The icons should now work as expected.

[LanesGood]

@sethvincent iOS now works for me! Android still errors, though I've applied the scripts in @geohacker's comment above

Error:

Execution failed for task ':app:mergeDebugResources'.
> Could not list contents of '/Users/lane/Github/observe/android/app/src/main/res/drawable-xxhdpi/*.png'. Couldn't follow symbolic link.```

Any issues that I should be resolving on my end, or is this still on the branch?

[sethvincent]

@LanesGood it took me awhile to figure out that the script at some point had a bug where it created a symlink with a filepath of /Users/lane/Github/observe/android/app/src/main/res/drawable-xxhdpi/*.png (note the filename *.png) that doesn't link to a real file.

You could try re-running ./scripts/link-icons.sh to make sure it works locally for you and that should also remove the offending file. Alternately take a look in Finder to see if a file named *.png exists and delete it. A quick way to open the directory in Finder:

open /Users/lane/Github/observe/android/app/src/main/res/drawable-xxhdpi/

Also: you only need to run ./scripts/link-icons.sh and it will take care of icons for both android and ios.

[sethvincent]

@geohacker I think this might be ready to merge. I haven't done any testing of searching for presets and adding features, but that might be best as a follow-up pr.