Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add observe api auth to accounts screen #142

Merged
merged 4 commits into from
Nov 25, 2019
Merged

add observe api auth to accounts screen #142

merged 4 commits into from
Nov 25, 2019

Conversation

geohacker
Copy link
Member

@geohacker geohacker commented Nov 25, 2019 •
edited
Loading

This PR adds Observe API authorization to the accounts screen. So now both OSM API and Observe API can be controlled from the same screen.

@geohacker
Copy link
Member Author

image

image

image

@geohacker geohacker marked this pull request as ready for review November 25, 2019 13:07
@batpad
Copy link
Member

batpad commented Nov 25, 2019

@geohacker works really well!

I added a couple of commits:

  • Removed the temporary testing buttons from the Settings screen (Login to API, Start Trace, End trace)
  • Added a button on the Settings screen to clear the Observe API token (which logs the user out of the Observe API, could be useful for debugging).

@geohacker geohacker merged commit df01e04 into develop Nov 25, 2019
@geohacker geohacker deleted the feature/observe-api-accounts branch November 25, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batpad batpad batpad approved these changes

@LanesGood LanesGood Awaiting requested review from LanesGood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geohacker @batpad