Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask user to log in if preauth url exists #112

Merged
merged 7 commits into from
Oct 25, 2019

Conversation

sethvincent
Copy link
Contributor

@sethvincent sethvincent commented Oct 23, 2019

This pr:

  • introduces PREAUTH_NAME env var to be used with PREAUTH_URL
  • if PREAUTH_URL exists the map will not render right away, instead a prompt will render asking the user to log in
  • updates react-native-cookies with some small improvements
  • adds a little documentation to the .env.sample file

@sethvincent
Copy link
Contributor Author

This now implements the idea that the map shouldn't be rendered until after authorization and provides an explicit login button

It also introduces a PREAUTH_NAME env var so that we can configure the name of the auth service.

There's some more testing I'd like to do to make sure this still works in various testing/production environments, but otherwise is very close to ready.

@sethvincent sethvincent changed the title {wip} preauth error debugging ask user to log in if preauth url exists Oct 25, 2019
app/services/api.js Outdated Show resolved Hide resolved
@geohacker
Copy link
Member

@sethvincent this looks really good to me. I tested it on both OSM production and dev on iOS and Android. Worked well 👍

@sethvincent sethvincent merged commit d048c47 into develop Oct 25, 2019
@sethvincent sethvincent deleted the preauth-error-debugging branch October 25, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants