Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces page #16

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Traces page #16

merged 6 commits into from
Nov 4, 2019

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Oct 30, 2019

The goal of this PR is to implement components for traces page according to the wireframes (#12).

At the moment, this PR includes:

  • State persistance, user will keep login after page reload
  • Loading traces from the API
  • Display of total traces count

To do:

  • Filter components
  • Pagination components
  • Table

@vgeorge
Copy link
Member Author

vgeorge commented Oct 31, 2019

@LanesGood I believe you can work on styling what you can for this page while I implement the Photos page. In order to populate the development database, please use code from developmentseed/observe-api#25 for the moment.

@LanesGood
Copy link
Member

LanesGood commented Nov 1, 2019

@vgeorge I'm running the API locally from the branch in developmentseed/observe-api#25 but the dev db is not populating.

Error message:

(node:64472) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 4)

@LanesGood
Copy link
Member

@vgeorge I've started setting up the layout for the pagination, and for the dropdown + length slider featured in this screen. Would you be able to help me hook up the dropdown and length filter so that I can start styling? This is mainly using components developed by @danielfdsilva that I'm not able to implement yet solo.

/cc @sethvincent if you want to take a look

@vgeorge vgeorge force-pushed the feature/traces-page branch from 900c5e7 to bf92a0c Compare November 4, 2019 18:57
@vgeorge
Copy link
Member Author

vgeorge commented Nov 4, 2019

@LanesGood as discussed, I'm merging this at the commit with basic page structure. I've moved last commits to enhance/trace-page-styles branch. Let's work on specific components in separate PRs to be able to review better.

@vgeorge vgeorge changed the title [WIP] Traces page Traces page Nov 4, 2019
@vgeorge vgeorge merged commit 91c628c into develop Nov 4, 2019
@vgeorge vgeorge deleted the feature/traces-page branch December 17, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants