Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set one-to-many relation between photos and OSM elements (and other changes) #36

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Set one-to-many relation between photos and OSM elements (and other changes) #36

merged 5 commits into from
Nov 26, 2019

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Nov 25, 2019

See #31.

@vgeorge vgeorge requested a review from batpad November 25, 2019 15:44
@vgeorge vgeorge changed the title Set relation one-to-many between photos and OSM elements Set one-to-many relation between photos and OSM elements Nov 25, 2019
@vgeorge vgeorge mentioned this pull request Nov 25, 2019
Closed
@vgeorge vgeorge mentioned this pull request Nov 26, 2019
Merged
@vgeorge vgeorge changed the title Set one-to-many relation between photos and OSM elements Set one-to-many relation between photos and OSM elements (and other changes) Nov 26, 2019
@vgeorge
Copy link
Member Author

vgeorge commented Nov 26, 2019

@batpad I added changes not related to the data schema, but I think you will be able to review as they are not complex.

Updated summary of changes:

You might want to use code from developmentseed/observe-dashboard#41 to browse populated data. I would recomend a local database cleanup before testing.

This is ready for review, please let me know if you have any questions.

batpad
batpad approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@batpad batpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me. Good catch on switching the data schema since a photo cannot be associated with more than 1 OSM feature.

@vgeorge vgeorge merged commit 3fa519b into develop Nov 26, 2019
@vgeorge vgeorge deleted the enhance/photo-to-osm-element branch November 26, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batpad batpad batpad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgeorge @batpad