Added overrideRootPath option. #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/add-override-root-path
branch
from
007d372 to
20720c2
Compare
pantierra
force-pushed
the
feature/add-override-root-path
branch
from
d1fb8fe to
8e08333
Compare
ciaransweet
reviewed
Jul 11, 2025
| readinessProbe: | ||
| httpGet: | ||
| {{- if .Values.multidim.overrideRootPath}} | ||
| path: {{ .Values.multidim.overrideRootPath }}/healthz |
There was a problem hiding this comment.
z in this is gross but that's another day 🤣
There was a problem hiding this comment.
Yes, please, this needs to be fixed upstream - fyi @vincentsarago
ciaransweet
reviewed
Jul 11, 2025
ciaransweet
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to EOEPCA/data-access#172
It introduces an optional attribute
overrideRootPathwhich allows to set a differentpathfor the ingress than the application is available for health checks and internal root path settings. This might be necessary when a different proxy configuration is being used.