Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate to Python API #37

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Add validate to Python API #37

merged 9 commits into from
Oct 10, 2024

Conversation

gadomski
Copy link
Collaborator

What I am changing

  • Add validate to Python API

How I did it

  • Tiny breaking change to core lib, return Error from to_json* methods instead of a serde_json::Error.
  • Convert to a custom Error type in the python bindings, per @kylebarron's suggestion: Python #30 (comment)

Related Issues

@gadomski gadomski self-assigned this Oct 10, 2024
@gadomski gadomski marked this pull request as ready for review October 10, 2024 16:34
@gadomski gadomski merged commit 66aef2c into main Oct 10, 2024
18 checks passed
@gadomski gadomski deleted the issues/34-validate branch October 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validate to Python API
2 participants