Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture output checks #17

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Add fixture output checks #17

merged 6 commits into from
Oct 1, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 1, 2024

What I am changing

  • Add expected output checks for each OGC example ... all inputs are tested against all output formats.

How I did it

  • Added a tests/generate-expected script to auto-create the outputs
  • I also did some refactoring of the OGC tests code
  • I cleaned up the CI a bit, mostly to remove the --all and --all-features flags since we don't have a workspace or features
  • I also fixed the CLIs to read to the end of stdin instead of just the first line
  • I took the liberty of adding an opinionated formatting option (imports_granularity) which opts in to a certain import style (the default is to not do anything around import style). I'm happy to remove that if folks like a different import style.

How you can test it

  • You could run the generation script yourself if you want

Related Issues

@gadomski gadomski self-assigned this Oct 1, 2024
@gadomski gadomski requested a review from bitner October 1, 2024 15:24
@gadomski gadomski force-pushed the issues/13-fixture-output branch from b7dd437 to e9b811d Compare October 1, 2024 15:25
@bitner bitner merged commit 6f161b8 into main Oct 1, 2024
1 check passed
@gadomski gadomski deleted the issues/13-fixture-output branch October 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fixtures for standardized output for all tests that come from the OGC examples.
2 participants