Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add relative URI support for baseURL #51

Merged
merged 5 commits into from
Oct 9, 2020
Merged

feat: add relative URI support for baseURL #51

merged 5 commits into from
Oct 9, 2020

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 31, 2020 •
edited
Loading

  • I've tried golfing the size ( but definitely don't have your skill :D , so feel free to tweak this @developit )

Closes #45

@Hotell Hotell force-pushed the hotell/add-baseurl-relative-path-support branch from ed365e9 to 6f28fc8 Compare July 31, 2020 18:56
@Hotell Hotell force-pushed the hotell/add-baseurl-relative-path-support branch from 6f28fc8 to 3b3c5e3 Compare August 1, 2020 08:54
developit
developit approved these changes Oct 9, 2020
View reviewed changes
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - I think my suggestion should cut the size down to near-zero.

src/index.js Outdated Show resolved Hide resolved
developit
developit reviewed Oct 9, 2020
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@developit
Copy link
Owner

Sweet, the regex is 10b smaller.

@developit developit merged commit 95a68f3 into developit:master Oct 9, 2020
@kallyas kallyas mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use relative URL for the baseURL option
2 participants
@Hotell @developit