fix: Resolving bug with relative baseURLs #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A bugfix(?), perhaps feature expansion.
Did you add tests for your changes?
Yes, a test was added to cover relative
baseURL's being used with Redaxios. Pretty much a copy/paste of the existing test but this time with a relative baseURL being used.Summary
This PR fixes the issue I've outlined in #45. As it was, Redaxios constructed its URL, if a
baseURLwas provided, withnew URL('/bar', '/foo');. However,/foowould not be a valid base URL and would cause an error if this was attempted.I fixed this with simple string concatenation. I'm not sure if there was a reason to use the URL constructor, so forgive me if I'm missing something, but string concatenation should do the trick, be ever so slightly smaller, and expand Redaxios' feature set to include relative baseURLs.
Does this PR introduce a breaking change?
No breaking changes