Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bundling using Rollup #59

Merged
merged 17 commits into from
Aug 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Karmatic [![npm](https://img.shields.io/npm/v/karmatic.svg)](https://npm.im/karmatic) [![travis](https://travis-ci.org/developit/karmatic.svg?branch=master)](https://travis-ci.org/developit/karmatic)

A simplified zero-configuration wrapper around [Karma], [Webpack], [Jasmine] & [Puppeteer].
Zero-config browser tests powered by [Karma] & [Puppeteer], with automatic [Rollup] & [Webpack] support.

Think of it like **Jest for cross-browser testing** - it even uses the same [expect syntax](https://jestjs.io/docs/en/using-matchers).

## Why do I want this?

Karma, Webpack and Jasmine are all great. They're all also quite powerful and each highly configurable. When creating and maintaining small modules, duplication of these configurations and dependencies is cumbersome.
Karma, Rollup/Webpack and Jasmine are all great. They're all also quite powerful and each highly configurable. When creating and maintaining small modules, duplication of these configurations and dependencies is cumbersome.

Karmatic is a zero-configuration wrapper around these tools with intelligent defaults, configuration auto-detection, and optimizations most configurations don't include.

Expand All @@ -15,7 +15,7 @@ Most importantly, Karmatic provides a (headless) browser test harness in a singl
## Installation

```sh
npm i -D webpack karmatic
npm i -D karmatic
```

... then add a `test` script to your `package.json`:
Expand All @@ -30,6 +30,8 @@ npm i -D webpack karmatic

... now you can run your tests using `npm t`. Here's a [minimal example repo](https://gist.github.com/developit/acd8a075350eeb6574439e92888c50cf).

If you have webpack set up in your project, it will be detected and your `webpack.config.js` will be used. Otherwise, Rollup is used to bundle tests and any `rollup.config.js` will be used if present.

### Test File Patterns

By default, Karmatic will find tests in any files ending in `.test.js` or `_test.js`.
Expand Down Expand Up @@ -95,6 +97,7 @@ Karmatic is pretty new! Here are some projects that have switched to it you may
[MIT](https://oss.ninja/mit/developit) © [developit](https://github.com/developit)

[karma]: https://karma-runner.github.io
[rollup]: https://rollupjs.org/
[webpack]: https://webpack.js.org
[jasmine]: https://jasmine.github.io
[puppeteer]: https://github.com/GoogleChrome/puppeteer
7 changes: 7 additions & 0 deletions e2e-test/default/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export function render(container) {
let div = document.createElement('div');
div.id = 'hello-world';
div.textContent = 'Hello World!';

container.appendChild(div);
}
16 changes: 16 additions & 0 deletions e2e-test/default/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { render } from './index';

describe('Hello World', () => {
it('should not be bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('undefined');
});

it('should be rendered to container', () => {
render(document.body);

let element = document.getElementById('hello-world');
expect(element).toBeTruthy();
expect(element.textContent).toBe('Hello World!');
});
});
14 changes: 14 additions & 0 deletions e2e-test/default/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"name": "karmatic-e2e-default",
"description": "Test default config in karmatic.",
"private": true,
"scripts": {
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"karmatic": "file:../.."
},
"devDependencies": {
"cross-env": "^7.0.2"
}
}
3 changes: 3 additions & 0 deletions e2e-test/rollup-custom/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function box(value) {
return { _value: value };
}
14 changes: 14 additions & 0 deletions e2e-test/rollup-custom/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { box } from './index';

describe('Box', () => {
it('should not be bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('undefined');
});

it('should have a __v property', () => {
const boxed = box(1);
expect('_value' in boxed).toBe(false);
expect(boxed.__v).toBe(1);
});
});
20 changes: 20 additions & 0 deletions e2e-test/rollup-custom/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"name": "karmatic-e2e-rollup-custom",
"description": "Test custom rollup config in karmatic",
"private": true,
"scripts": {
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"@babel/core": "^7.10.3",
"@rollup/plugin-babel": "5.2.0",
"@rollup/plugin-commonjs": "^14.0.0",
"@rollup/plugin-node-resolve": "^8.4.0",
"babel-plugin-transform-rename-properties": "^0.1.0",
"rollup": "^2.3.0",
"karmatic": "file:../../"
},
"devDependencies": {
"cross-env": "^7.0.2"
}
}
24 changes: 24 additions & 0 deletions e2e-test/rollup-custom/rollup.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import nodeResolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import babel from '@rollup/plugin-babel';

export default {
input: 'index.js',
output: {
dir: 'dist',
format: 'es',
},
plugins: [
babel({
babelHelpers: 'bundled',
plugins: [
[
'babel-plugin-transform-rename-properties',
{ rename: { _value: '__v' } },
],
],
}),
nodeResolve(),
commonjs(),
],
};
15 changes: 15 additions & 0 deletions e2e-test/rollup-default/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"name": "karmatic-e2e-rollup-default",
"description": "Test default rollup config in karmatic. Mildly complex src implementation to verify coverage works",
"private": true,
"scripts": {
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"rollup": "^2.3.0",
"karmatic": "file:../.."
},
"devDependencies": {
"cross-env": "^7.0.2"
}
}
29 changes: 29 additions & 0 deletions e2e-test/rollup-default/src/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
export function combine(input1, input2) {
const isInput1Array = Array.isArray(input1);
const isInput2Array = Array.isArray(input2);

if (typeof input1 !== typeof input2 || isInput1Array !== isInput2Array) {
const input1Type = isInput1Array ? 'array' : typeof input1;
const input2Type = isInput2Array ? 'array' : typeof input2;
throw new Error(
`Types of inputs are not the same: input1=${input1Type}, input2=${input2Type}`
);
}

if (typeof input1 == 'string' || typeof input1 == 'number') {
return input1 + input2;
}

if (isInput1Array) {
return [...input1, ...input2];
}

if (typeof input1 == 'object') {
return {
...input1,
...input2,
};
}

throw new Error(`Unsupported type: ${typeof input1}`);
}
48 changes: 48 additions & 0 deletions e2e-test/rollup-default/test/combine.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import { combine } from '../src/index';

describe('combine', () => {
it('should concatenate strings', () => {
expect(combine('a', 'b')).toBe('ab');
});

it('should add numbers', () => {
expect(combine(1, 2)).toBe(3);
});

it('should concatenate arrays', () => {
expect(combine([1, 2], ['a', 'b'])).toEqual([1, 2, 'a', 'b']);
});

it('should merge objects', () => {
expect(combine({ a: 1, b: 2 }, { c: 'c', d: 'd', a: 'a' })).toEqual({
a: 'a',
b: 2,
c: 'c',
d: 'd',
});
});

it('throw an error if types do not match', () => {
expect(() => combine('a', 1)).toThrow();
expect(() => combine(1, 'a')).toThrow();

expect(() => combine([1], 1)).toThrow();
expect(() => combine(1, [1])).toThrow();

expect(() => combine({}, 2)).toThrow();
expect(() => combine(1, {})).toThrow();
});

it('throw an error if type is unsupported', () => {
expect(() =>
combine(
() => {},
() => {}
)
).toThrow();

expect(() => combine(true, false)).toThrow();

expect(() => combine(Symbol.for('a'), Symbol.for('b'))).toThrow();
});
});
15 changes: 15 additions & 0 deletions e2e-test/rollup-default/test/custom-pragma.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/** @jsx createElement */

describe('Custom JSX Pragma', () => {
it('should use custom babel config', () => {
let h = jasmine.createSpy('h');
let createElement = jasmine.createSpy('createElement');
let React = { createElement: jasmine.createSpy('React.createElement') };

<div id="foo">hello</div>;

expect(h).not.toHaveBeenCalled();
expect(React.createElement).not.toHaveBeenCalled();
expect(createElement).toHaveBeenCalledWith('div', { id: 'foo' }, 'hello');
});
});
24 changes: 24 additions & 0 deletions e2e-test/rollup-default/test/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
const sleep = (ms) => new Promise((r) => setTimeout(r, ms));

describe('Basic test functions', () => {
it('should be not bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('undefined');
});

it('should work', () => {
expect(1).toEqual(1);
});

it('should handle deep equality', () => {
expect({ foo: 1 }).toEqual({ foo: 1 });
});

it('should handle async tests', async () => {
let start = Date.now();
await sleep(100);

let now = Date.now();
expect(now - start).toBeGreaterThan(50);
});
});
9 changes: 9 additions & 0 deletions e2e-test/rollup-default/test/jest-style.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
describe('jest-style', () => {
describe('not.stringContaining', () => {
const expected = 'Hello world!';

it('matches if the received value does not contain the expected substring', () => {
expect('How are you?').toEqual(expect.not.stringContaining(expected));
});
});
});
6 changes: 6 additions & 0 deletions e2e-test/webpack-custom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@
"name": "karmatic-e2e-webpack-custom",
"description": "Test custom webpack config in karmatic using a custom Babel config",
"private": true,
"scripts": {
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"@babel/core": "^7.10.3",
"babel-loader": "8.1.0",
"babel-plugin-transform-rename-properties": "^0.1.0",
"karmatic": "file:../..",
"webpack": "^4.44.1"
},
"devDependencies": {
"cross-env": "^7.0.2"
}
}
5 changes: 5 additions & 0 deletions e2e-test/webpack-custom/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { box } from '../src/index';

describe('Box', () => {
it('should be bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('function');
});

it('should have a __v property', () => {
const boxed = box(1);
expect('_value' in boxed).toBe(false);
Expand Down
3 changes: 2 additions & 1 deletion e2e-test/webpack-default/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"private": true,
"scripts": {
"test": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js run",
"test:watch": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js --headless false"
"test:watch": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js --headless false",
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"karmatic": "file:../..",
Expand Down
5 changes: 5 additions & 0 deletions e2e-test/webpack-default/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
const sleep = (ms) => new Promise((r) => setTimeout(r, ms));

describe('Basic test functions', () => {
it('should be bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('function');
});

it('should work', () => {
expect(1).toEqual(1);
});
Expand Down
5 changes: 5 additions & 0 deletions e2e-test/webpack-loader/index.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { getWorker } from './index';

describe('demo', () => {
it('should be bundled using webpack', () => {
// eslint-disable-next-line camelcase
expect(typeof __webpack_require__).toBe('function');
});

it('should do MAGIC', async () => {
let worker = getWorker();

Expand Down
6 changes: 6 additions & 0 deletions e2e-test/webpack-loader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@
"name": "karmatic-e2e-webpack-workerize-loader",
"description": "Test customer webpack loader testing in karmatic",
"private": true,
"scripts": {
"test:debug": "cross-env NODE_PRESERVE_SYMLINKS_MAIN=1 NODE_PRESERVE_SYMLINKS=1 node ./node_modules/karmatic/dist/cli.js debug"
},
"dependencies": {
"webpack": "^4.44.1",
"workerize-loader": "^1.3.0",
"karmatic": "file:../.."
},
"devDependencies": {
"cross-env": "^7.0.2"
}
}
5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
"@babel/core": "^7.11.0",
"@babel/plugin-transform-react-jsx": "^7.10.3",
"@babel/preset-env": "^7.11.0",
"@rollup/plugin-babel": "^5.1.0",
"@rollup/plugin-commonjs": "^14.0.0",
"@rollup/plugin-node-resolve": "^8.4.0",
"babel-loader": "^8.1.0",
"babel-plugin-istanbul": "^6.0.0",
"chalk": "^2.3.0",
Expand All @@ -59,11 +62,13 @@
"karma-firefox-launcher": "^1.3.0",
"karma-jasmine": "^4.0.0",
"karma-min-reporter": "^0.1.0",
"karma-rollup-preprocessor": "^7.0.5",
"karma-sauce-launcher": "^4.1.5",
"karma-sourcemap-loader": "^0.3.7",
"karma-spec-reporter": "0.0.32",
"karma-webpack": "^4.0.2",
"minimatch": "^3.0.4",
"rollup": "^2.3.4",
"sade": "^1.7.3",
"simple-code-frame": "^1.0.0"
},
Expand Down
Loading