Upgrade Karma and puppeteer #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most breaking changes seem related to dropping older NodeJS support. Upgrading deps has benefit of bringing in newer versions of sub deps
developit
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karma and puppeteer were approaching a year old so wanted to bring them up to date.
Breaking changes in karma 5:
I don't think any of these affect our plugins as all our tests pass. I mainly wanted to upgrade Karma cuz it includes some slightly better error reporting for "unhandlerejections" which I hit recently.
Also wanted to upgrade puppeteer to reduce the likelihood of consumers downloading multiple copies of puppeteer. Perhaps for the next major version we should consider making puppeteer a peerDep so consumers can control which version of Chromium their tests run against?