-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nodenext module support from TypeScript 4.7 #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wight554
commented
Apr 25, 2022
- as per Bug: Typescript(4.6+) moduleResolve mode node12 nodenext do not shadow package.json filds types and main microsoft/TypeScript#48235 (comment)
- follow-up support nodenext in TypeScript 4.7 preactjs/preact#3513
Can be shimmed by:
But it would be better to fix it properly |
cc @developit |
developit
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me!
developit
reviewed
Apr 26, 2022
This was referenced Jul 16, 2024
This was referenced Sep 7, 2024
[Snyk] Upgrade: react, react-dom, htm
WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#502
Open
This was referenced Sep 14, 2024
[Snyk] Upgrade: react, react-dom, htm
WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#508
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.