feat: add MemoLazy function that recomputes value if selected value has changed #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mmaietta
reviewed
Jul 3, 2024
mmaietta
approved these changes
Jul 4, 2024
mmaietta
reviewed
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi develar, just submitting a PR to add an additional
MemoLazyfunction that recomputes thecreatorif the value returned from theselectorhas changed. This is to workaround the following issue withinelectron-builder:I've avoided adding external libs to minimize the overhead, and I've added two tests to try to illustrate the differences in behaviour.
Feel free to close if you think this is out of scope, or let me know if you have any suggested changes.