Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anaconda] Devcontainer maintenance: Remove outdated patches #891

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[anaconda] Devcontainer maintenance: Remove outdated patches #891

merged 1 commit into from
Dec 13, 2023

Conversation

alexander-smolyakov
Copy link
Contributor

Dev container name:

  • anaconda

Description:

Last month a newer version of continuumio/anaconda3 was released. This version ships with updated versions of the Python packages. Thus, we can revisit our patches and see which patches could be removed from the devcontainer.

I checked the versions of the packages in continuumio/anaconda3, and here are the results:

Results
(base) root@1a82830ff111:/# conda list pyopenssl
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
pyopenssl                 23.2.0          py311h06a4308_0

(base) root@1a82830ff111:/# conda list cryptography
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
cryptography              41.0.3          py311hdda0065_0

(base) root@1a82830ff111:/# conda list requests
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
requests                  2.31.0          py311h06a4308_0

(base) root@1a82830ff111:/# conda list mpmath
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
mpmath                    1.3.0           py311h06a4308_0

(base) root@1a82830ff111:/# conda list aiohttp
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
aiohttp                   3.8.5           py311h5eee18b_0

(base) root@1a82830ff111:/# conda list pillow
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
pillow                    9.4.0           py311h6a678d5_1

(base) root@1a82830ff111:/# conda list urllib3
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
urllib3                   1.26.16         py311h06a4308_0

(base) root@1a82830ff111:/# conda list joblib
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
joblib                    1.2.0           py311h06a4308_0

(base) root@1a82830ff111:/# conda list cookiecutter
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
cookiecutter              1.7.3              pyhd3eb1b0_0

(base) root@1a82830ff111:/# conda list mistune
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
mistune                   0.8.4           py311h5eee18b_1000

(base) root@1a82830ff111:/# conda list numpy
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
numpy                     1.24.3          py311h08b1b3b_1
numpy-base                1.24.3          py311hf175353_1
numpydoc                  1.5.0           py311h06a4308_0

(base) root@1a82830ff111:/# conda list werkzeug
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
werkzeug                  2.2.3           py311h06a4308_0

(base) root@1a82830ff111:/# conda list nbconvert
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
nbconvert                 6.5.4           py311h06a4308_0

(base) root@1a82830ff111:/# conda list tornado
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
tornado                   6.3.2           py311h5eee18b_0

(base) root@1a82830ff111:/# conda list transformers
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
transformers              4.32.1          py311h06a4308_0

Considering the results, I removed unactual patches because the upstream contains all the patched versions.

Changelog:

Dockerfile:

  • Removed outdated patches to be in sync with the upstream image;

Checklist:

  • Checked that applied changes work as expected;

- Removed outdated patches to be in sync with upstream image;
@alexander-smolyakov alexander-smolyakov requested a review from a team as a code owner December 13, 2023 13:33
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eljog eljog merged commit 136221f into devcontainers:main Dec 13, 2023
3 checks passed
@alexander-smolyakov alexander-smolyakov deleted the anaconda-remove_outdated_patches branch December 14, 2023 06:05
@eljog eljog mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants