-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[desktop-lite] Allow password-less VNC connections #982
[desktop-lite] Allow password-less VNC connections #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time in contributing this PR. The changes make sense to me ✨
Left some minor comments
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
…rger/features into hoechenberger/issue611
Thanks @samruddhikhandale, I've adopted your proposal (needed to apply a small fix to make it work) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Thank you, @samruddhikhandale! One question: The feature has apparently indeed been built and published. However, the bot didn't add a new tag on GH. Is this expected? |
@hoechenberger Which bot are you mentioning here, where do you expect the new tag? https://github.com/devcontainers/features/pkgs/container/features%2Fdesktop-lite looks good to me as you already mentioned. |
@samruddhikhandale I don't know which bot would be responsible, but I see that there are numerous tags for (older?) versions of many features in the repo, see: https://github.com/devcontainers/features/tags |
Got it, @joshspicer do you mind reminding us why we saw tags before, but we stopped couple of months ago? I wonder if this was intentional or a regression. |
This allows setting:
to start the VNC server such that it won't require authentication when trying to connect.
Closes #611
@jhollowe can you please try if this works for you?