Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[desktop-lite] Allow password-less VNC connections #982

Merged

Conversation

hoechenberger
Copy link
Contributor

@hoechenberger hoechenberger commented May 26, 2024

This allows setting:

    "ghcr.io/devcontainers/features/desktop-lite:1": {
      "password": "noPassword"
    }

to start the VNC server such that it won't require authentication when trying to connect.

Closes #611

@jhollowe can you please try if this works for you?

@hoechenberger hoechenberger requested a review from a team as a code owner May 26, 2024 12:33
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time in contributing this PR. The changes make sense to me ✨

Left some minor comments

src/desktop-lite/install.sh Outdated Show resolved Hide resolved
src/desktop-lite/README.md Outdated Show resolved Hide resolved
hoechenberger and others added 4 commits May 29, 2024 08:54
@hoechenberger
Copy link
Contributor Author

Thanks @samruddhikhandale, I've adopted your proposal (needed to apply a small fix to make it work)

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@samruddhikhandale samruddhikhandale merged commit 476a68d into devcontainers:main May 29, 2024
12 checks passed
@hoechenberger hoechenberger deleted the hoechenberger/issue611 branch May 29, 2024 19:57
@hoechenberger
Copy link
Contributor Author

Thank you, @samruddhikhandale!

One question: The feature has apparently indeed been built and published. However, the bot didn't add a new tag on GH. Is this expected?

@samruddhikhandale
Copy link
Member

@hoechenberger Which bot are you mentioning here, where do you expect the new tag?

https://github.com/devcontainers/features/pkgs/container/features%2Fdesktop-lite looks good to me as you already mentioned.

@hoechenberger
Copy link
Contributor Author

@samruddhikhandale I don't know which bot would be responsible, but I see that there are numerous tags for (older?) versions of many features in the repo, see: https://github.com/devcontainers/features/tags

@samruddhikhandale
Copy link
Member

@samruddhikhandale I don't know which bot would be responsible, but I see that there are numerous tags for (older?) versions of many features in the repo, see: https://github.com/devcontainers/features/tags

Got it, @joshspicer do you mind reminding us why we saw tags before, but we stopped couple of months ago? I wonder if this was intentional or a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[desktop-lite] Option to have password-less, autoconnecting noVNC
2 participants